Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/android-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f2af06f
Choose a base ref
...
head repository: dotnet/android-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 26d65d9
Choose a head ref
  • 2 commits
  • 23 files changed
  • 2 contributors

Commits on Oct 3, 2020

  1. [Xamarin.Android.Tools.AndroidSdk] Error & Warning Localization (#96)

    Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/
    Context: dotnet/android@0342fe5
    
    Localize error and warning messages produced by
    `Xamarin.Android.Tools.AndroidSdk.dll`.
    
    We will be following the [.NET Resource Localization pattern][0] and
    generating satellite assemblies using [`.resx` files][1], in particular
    `src/Xamarin.Android.Tools.AndroidSdk/Properties/Resources.resx`.
    
    `Resources.resx` is an XML file, and will contain `/root/data`
    elements in which `//data/@name` will be a semantically meaningful
    shorthand for the actual error message, followed by a `_`-separated
    list of "parameter names" for the message, if the message has any
    format string placeholders.  The `//data/value` will
    be the error or warning message:
    
    	<root>
    	  <data name="InvalidMonodroidConfigFile_path_message" xml:space="preserve">
    	    <value>An exception occurred while reading configuration file '{0}'. Exception: {1}</value>
    	    <comment>
    	{0} - The path of the file being read.
    	{1} - The exception message of the associated exception.
    	    </comment>
    	  </data>
    	</root>
    
    An optional `//data/comment` element may be provided to describe the
    meaning within the `//data/value` element to translators.
    
    When using Visual Studio or Visual Studio for Mac, changes to
    `Resrouces.resx` will cause `Resources.Designer.cs` to be updated:
    
    	namespace Xamarin.Android.Tools.AndroidSdk.Properties {
    	  internal partial class Resources {
    	    internal static string InvalidMonodroidConfigFile_path_message {
    	      get => …
    	    }
    	  }
    	}
    
    The `Resources` members should be used to obtain all strings for use
    in `logger()` calls:
    
    	logger (TraceLevel.Error, string.Format (Resources.InvalidMonodroidConfigFile_path_message, file, ex.Message));
    
    When an MSBuild error or warning code is used with more than one
    output string, then a semantically meaningful suffix should be used
    to distinguish between the two.
    
    Note that this infrastructure does not interoperate with C#6 string
    interpolation.  Any error or warning messages currently using C#6
    string interpolation will need to use .NET 1.0-style format strings.
    
    Our translation team doesn't work directly with `.resx` files.
    Instead, the translation team works with [XLIFF files][2].
    `Resources.resx` is converted into a set of
    `src/Xamarin.Android.Build.Tasks/Properties/xlf/Resources.*.xlf`
    files via `XliffTasks.targets` from the [dotnet/xliff-tasks][3] repo.
    The `Resources.*.xlf` files should be automatically updated whenever
    `Resources.resx` is updated.
    
    [0]: https://docs.microsoft.com/dotnet/framework/resources/index
    [1]: https://docs.microsoft.com/dotnet/framework/resources/creating-resource-files-for-desktop-apps#resources-in-resx-files
    [2]: http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html
    [3]: https://github.com/dotnet/xliff-tasks
    moljac authored Oct 3, 2020
    Configuration menu
    Copy the full SHA
    1878e43 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. [Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-30 (#99)

    Context: https://dl-ssl.google.com/android/repository/repository2-1.xml
    
    Update the preferred Android SDK component versions to the current latest
    versions listed in the [Android Repository file][0]:
    
      * `$(AndroidSdkBuildToolsVersion)`/build-tools to 30.0.2
      * `$(AndroidCommandLineToolsVersion)`/cmdline-tools to 2.1
      * `$(AndroidSdkPlatformToolsVersion)`/platform-tools to 30.0.4
      * `$(AndroidSdkPlatformVersion)`/platform to android-30
      * `$(AndroidNdkVersion)`/NDK to 21.3.6528147
    
    [0]: https://dl-ssl.google.com/android/repository/repository2-1.xml
    jonpryor authored Oct 19, 2020
    Configuration menu
    Copy the full SHA
    26d65d9 View commit details
    Browse the repository at this point in the history
Loading