Avoid Environment.SpecialFolder.ApplicationData (#188)

Rodrigo Moya · jonathanpeppers · web-flow · commit 3c55e9af892b · 2022-08-02T10:04:51.000-05:00
* Don't use ApplicationData for config file on UNIX

When running on NET6 (VSMac installer), SpecialFolder.ApplicationData
returns nothing, resulting in a relative path being used for the config
file. So, just switch to use UserProfile, to which we append .config
for the well known, and expected, place for the config file.

Example testing with Mono's `csharp` command:

    $ csharp
    Mono C# Shell, type "help;" for help
    Enter statements below.
    csharp&gt; Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData)                                                                                      
    "/Users/jopepper/.config"                                                                                                                                     
    csharp&gt; Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)                                                                                          
    "/Users/jopepper"     

Co-authored-by: Jonathan Peppers &lt;jonathan.peppers@microsoft.com&gt;
diff --git a/src/Xamarin.Android.Tools.AndroidSdk/Sdks/AndroidSdkUnix.cs b/src/Xamarin.Android.Tools.AndroidSdk/Sdks/AndroidSdkUnix.cs
@@ -223,8 +223,7 @@ private static string UnixConfigPath {
 			get {
 				var p   = AppDomain.CurrentDomain.GetData (GetUnixConfigDirOverrideName)?.ToString ();
 				if (string.IsNullOrEmpty (p)) {
-					p   = Environment.GetFolderPath (Environment.SpecialFolder.ApplicationData);
-					p   = Path.Combine (p, "xbuild");
+					p   = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), ".config", "xbuild");
 				}
 				return Path.Combine (p, "monodroid-config.xml");
 			}

Original file line number	Diff line number	Diff line change
`@@ -223,8 +223,7 @@ private static string UnixConfigPath {`
`223`	`223`	`get {`
`224`	`224`	`var p = AppDomain.CurrentDomain.GetData (GetUnixConfigDirOverrideName)?.ToString ();`
`225`	`225`	`if (string.IsNullOrEmpty (p)) {`
`226`		`- p = Environment.GetFolderPath (Environment.SpecialFolder.ApplicationData);`
`227`		`- p = Path.Combine (p, "xbuild");`
	`226`	`+ p = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), ".config", "xbuild");`
`228`	`227`	`}`
`229`	`228`	`return Path.Combine (p, "monodroid-config.xml");`
`230`	`229`	`}`