Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/android-libzipsharp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.1.1
Choose a base ref
...
head repository: dotnet/android-libzipsharp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.3.0
Choose a head ref
  • 9 commits
  • 23 files changed
  • 4 contributors

Commits on Feb 21, 2024

  1. [ci] Migrate to the 1ES template (#135)

    * [ci] Migrate to the 1ES template
    
    Context: https://aka.ms/1espt
    
    The build pipeline has been updated to extend the 1ES pipeline template,
    which will keep the pipeline up to date with the latest compliance and
    security requirements.
    
    Compliance tasks and scans will run automatically as part of artifact
    upload steps, which are now referred to as "outputs".  Template outputs
    have replaced all instances of the `PublishPipelineArtifact` task.
    
    * Use self template reference
    
    * Test 1es-sign-artifacts yaml branch
    
    * Set compiler/linker flags
    
    * Test removal of xz submodule
    
    * Update flags
    
    * Update flags
    
    * Test template pivot
    
    * Add scan suppressions
    
    * Use main templates branch
    
    * Import more suppressions
    
    * Bump to xz 5.4.6
    
    * Update .gdn
    
    * Use github.com/tukaani-project/xz
    
    * Update suppressions path
    
    * Update conditions and cl/link flags
    
    * Update cl/link flags
    
    * Update flags
    
    * Try a different way to pass args to submodules
    
    * Disable a warning we can't do much about
    
    * Update gdnsuppress:
    
    * Update build_windows, gdnsuppress
    
    * Update gdnsuppress
    
    * Update build images
    
    * Install latest 7.0 sdk for test lanes
    
    * Use latest 7.0 sdk
    
    ---------
    
    Co-authored-by: Marek Habersack <[email protected]>
    pjcollins and grendello authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    577147e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    afef4b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    8bc799c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. [ci] Use managed identity for API Scan (#138)

    I've configured a new [managed identity][0] (MSI) for API Scan, which
    allows us to enable a more modern authentication approach when
    running API Scan on the `MAUI-1ESPT` agent pool.
    
    A new `$(ApiScanMAUI1ESPTManagedId)` variable has been configured in
    the pipeline settings to pass the app ID for this MSI to the
    API Scan task.
    
    [0]: https://ms.portal.azure.com/#@microsoft.onmicrosoft.com/resource/subscriptions/cd4829e2-e38b-43d2-8316-2f2009f36f97/resourcegroups/1esobjects/providers/microsoft.managedidentity/userassignedidentities/maui1esptapiscanidentity/overview
    pjcollins authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    336a86f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Remove LZMA (XZ) support (#139)

    Context: https://tukaani.org/xz-backdoor/
    
    In light of the recently discovered backdoor in xz-utils and its
    GitHub repository being blocked, remove the submodule from LibZipSharp
    and remove all the code to enable lzma compression support in it.
    
    Note that XZ support was disabled by default and was never released
    as part of any official LibZipSharp nugets/binaries, therefore we
    are not affected in any form or shape by the issue.
    
    The submodule is removed so that it is possible to clone and initialize
    this repository.  When the issues surrounding xz-utils are fixed, we can
    restore support by reverting this commit.
    grendello authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    14f591c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    4fef46a View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Update OneLocBuildToken (#141)

    * Update OneLocBuildToken
    * Force loc task pool image to windows
    MSylvia authored May 25, 2024
    Configuration menu
    Copy the full SHA
    c2ae332 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Fix the elusive invalid zip archive issue that has been a problem for…

    … ages! (#142)
    
    * Fix the elusive invalid zip archive issue that has been a problem for ages!
    
    Fixes dotnet/android#8988
    
    We had this odd corrupt zip file issue which kept cropping up on our Azure Pipelines builds.
    We had no idea what caused it until now. Some of the data for the local headers of an item (not the central directory) would be written incorrectly. This would result in a zip which may or may not be extractable, it would depend on how resilient the software extracting the data would be.
    
    So, what was happening here was that (sometimes) libzip would start writing some data (most likely the local file header) using our stream source callback, and it would seek a few bytes into the data and then tried to seek back to the beginning. The latter seek was done by giving the seek operation of the callback an offset of 0 which, unfortunately, was also used by the code as a guard as to whether or not to even perform the seek operation. The effect was that we ignored the seek to 0 and the stream remained at whatever the previous seek location was requested, thus corrupting data. It happened only on the very first entry, since that was the only one which would have position 0 within its range.
    
    We discovered that just enabling the strict consistency checks would uncover the issue, so that has been enabled in
    a number of unit tests. Once we did that it turns out we were writting the corrupt data ALL the TIME!.
    Fixing up the seeking code to take into account that we might want to see to 0 fixed the issue.
    
    * Bump to 3.3.0 due to ABI changes
    dellis1972 authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b541b87 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de57dcc View commit details
    Browse the repository at this point in the history
Loading