Fix for issue 0064 AndroidX.AppCompat.Resources FileNotFound if bundle assemblies is set to true. #106
Conversation
moljac
added
do-not-merge
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@moljac I've tried nugets from https://github.com/moljac/Samples.AndroidX/tree/master/nuget-local with X.F 4.6 and don't see any issues. Images are displayed, no FileNotFoundException. Looks like fix works. I'll continue using your nugets and report here in case of any problems. Thanks! |
|
No! Thank you! Really appreciated. I'm waiting feedback from Xamarin.Forms team and must publish nugets. If you would be so kind and drop the note in the issue. Just short feedback that it works for you. For the record. |
…hub.com/xamarin/AndroidX into master_based_issue0064_BundleAssemblies
…hub.com/xamarin/AndroidX into master_based_issue0064_BundleAssemblies
|
Any hopes to merge this and include in release soon? |
|
@Skirtek Merge will not fix it, because packages with fix are already published. The only problem is - Xamarin.Forms team must update their packages. |
PR codename - Bleach Antidote
Support Libraries Version (eg: 23.3.0):
AndroidX
Does this change any of the generated binding API's?
Yes.
No. with type forwarding.
Describe your contribution
Naming convention in AndroidX created managed
AndroidX.AppCompat.Resources.dllfor the androidx.appcompat.appcpmpat-resources artifact.This assembly is bundled if bundling assemblies is set to true, which some users use as obfuscation and size reduction tool, though this tool's intention is different.
The users have been warned not to use bundling assemblies for obfuscation and size reduction, but seems that bleach-for-virii movement is worldwide phenomena, so we are creating antidote that will be shipped with CIF and Domestos products. Thus the codename "Bleach antidote".
Steps done:
config.jsontoAndroidX.AppCompat.AppCompatResources.dllfor the old projectandroidx.appcomapt.appcompat-resources.csprojwhich contains bindings (metadata transforms and code)androidx.appcompat.appcompat-resources-typeforwarders.csprojwhich generates old assemblyAndroidX.AppCompat.Resources.dllwith typeforwarders to new assemblyAndroidX.AppCompat.AppCompatResources.dllandroidx.appcompat.appcompat-resources-typeforwarders.csprojgenerating old assemblyAndroidX.AppCompat.Resources.dllreferences old projectandroidx.appcomapt.appcompat-resources.csprojwhich generates assembly with new nameAndroidX.AppCompat.AppCompatResources.dllIssues fixed:
System.IO.FileNotFoundException when
<BundleAssemblies>True</BundleAssemblies>[Bug] [Android] System.IO.FileNotFoundException when <BundleAssemblies>True</BundleAssemblies> #64
Related issues:
[Bug] Image Control doesn't work #9900
Xamarin.Forms repo
[Bug] Image Control doesn't work xamarin/Xamarin.Forms#9900
[Bug] java.lang.ClassNotFoundException: androidx.appcompat.widget.FitWindowsFrameLayout Fix typo in MediaLibraryService method name: OnGetSeesionFromMediaLibraryService -> OnGetSessionFromMediaLibraryService #1198
Xamarin.Essentials repo
[Bug] java.lang.ClassNotFoundException: androidx.appcompat.widget.FitWindowsFrameLayout xamarin/Essentials#1198