[Xamarin.Android.Build.Tasks] unify $(AndroidCodegenTarget)
#9806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbb0b92 introduced `$(_AndroidCodeGenerationTarget)`, but I didn't notice that `$(AndroidCodegenTarget)` already exists! Unify on `$(AndroidCodegenTarget)`, making the defaults: * `$(AndroidCodegenTarget)=XAJavaInterop1` if blank, when not using NativeAOT * `$(AndroidCodegenTarget)=JavaInterop1` if blank, when using NativeAOT
jonathanpeppers
commented
Feb 18, 2025
| <TargetFrameworkVersion Condition="'$(TargetFrameworkVersion)' == '' And '$(AndroidUseLatestPlatformSdk)' == 'False'">v5.0</TargetFrameworkVersion> | ||
| <LangVersion Condition=" '$(LangVersion)' == '' ">8.0</LangVersion> | ||
| <AndroidClassParser Condition=" '$(AndroidClassParser)' == '' ">jar2xml</AndroidClassParser> | ||
| <AndroidCodegenTarget Condition=" '$(AndroidCodegenTarget)' == '' ">XAJavaInterop1</AndroidCodegenTarget> |
Member
Author
There was a problem hiding this comment.
This should already be set in Microsoft.Android.Sdk.DefaultProperties.targets.
jonathanpeppers
requested review from
dellis1972 and
jonpryor
as code owners
dellis1972
approved these changes
Feb 19, 2025
grendello
added a commit
that referenced
this pull request
Feb 20, 2025
* main: Bump com.android.tools.build:manifest-merger from 31.8.0 to 31.8.1 (#9800) [Xamarin.Android.Build.Tasks] unify `$(AndroidCodegenTarget)` (#9806) Bump to dotnet/java-interop@f30e420a (#9793)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbb0b92 introduced
$(_AndroidCodeGenerationTarget), but I didn't notice that$(AndroidCodegenTarget)already exists!Unify on
$(AndroidCodegenTarget), making the defaults:$(AndroidCodegenTarget)=XAJavaInterop1if blank, when not using NativeAOT$(AndroidCodegenTarget)=JavaInterop1if blank, when using NativeAOT