Bump to dotnet/java-interop/main@e288589d #9721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does It Build™?
Contributor
Author
|
Unit tests don't compile because |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Changes: dotnet/java-interop@9b1d878...e288589 * dotnet/java-interop@e288589d: [Java.Interop] Add JniRuntime.JniValueManager.GetPeer() (dotnet/java-interop#1295) * dotnet/java-interop@bbb15b71: [ci] Add dev/* branches to CI trigger (dotnet/java-interop#1297)
jonpryor
changed the title
Contributor
Author
|
Draft commit message: Bump to dotnet/java-interop/main@e288589d (#9721)
Changes: https://github.com/dotnet/java-interop/compare/9b1d8781e8e322849d05efac32119c913b21c192...e288589d92afc9edd9070638ebed72f67e310117
* dotnet/java-interop@e288589d: [Java.Interop] Add JniRuntime.JniValueManager.GetPeer() (dotnet/java-interop#1295)
* dotnet/java-interop@bbb15b71: [ci] Add dev/* branches to CI trigger (dotnet/java-interop#1297) |
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- external/Java.Interop: Language not supported
Comments suppressed due to low confidence (2)
tests/Mono.Android-Tests/Java.Interop-Tests/Java.InteropTests/AndroidValueManagerContractTests.cs:15
- [nitpick] The class name 'AndroidValueManagerContractTests' could be more descriptive. Consider renaming it to reflect the specific aspect of 'AndroidValueManager' it is testing.
public class AndroidValueManagerContractTests : JniRuntimeJniValueManagerContract {
tests/Mono.Android-Tests/Java.Interop-Tests/Java.InteropTests/AndroidValueManagerContractTests.cs:17
- There is no test to verify the behavior of the 'ValueManagerType' property. Consider adding a test to ensure the override is functioning as expected.
protected override Type ValueManagerType => typeof (Android.Runtime.AndroidValueManager);
jonathanpeppers
approved these changes
Jan 30, 2025
dellis1972
approved these changes
Jan 30, 2025
grendello
added a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: dotnet/java-interop@9b1d878...e288589