[build] remove unused Xamarin.Android files #9719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two files cause some confusion by *existing* in the repo: * `Xamarin.Android.Sdk.props` * `Xamarin.Android.Sdk.targets` Neither are shipped in `C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\`, for example. They are effectively dead code. If we remove them, this means more stuff can be removed: * `@(XATargetsSrcFiles)` item group * `<SetVsMonoAndroidRegistryKey/>` MSBuild task * `create-vsix` and `create-pkg` projects * `Xamarin.Android.Bindings.Before.targets` and `Xamarin.Android.Bindings.After.targets` * `Xamarin.Android.Common.Before.targets` and `Xamarin.Android.Common.After.targets` Removing these files may improve MSBuild project evaluation time, as they are currently running several `Exists()` checks that always return `false`. In the Xamarin.Android days, the XamarinVS Visual Studio extension layed down custom MSBuild targets files *inside* the Xamarin.Android installation to augment the build. This doesn't happen any more in .NET 6+, as they do not lay down files inside a .NET workload in `C:\Program Files\dotnet\packs`. It wouldn't make sense to do so. Note that I moved `runtime-entitlements.plist` to `build-tools/installers/` as it is still used.
dellis1972
approved these changes
Jan 29, 2025
pjcollins
approved these changes
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two files cause some confusion by existing in the repo:
Xamarin.Android.Sdk.propsXamarin.Android.Sdk.targetsNeither are shipped in
C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\, for example. They are effectively dead code.If we remove them, this means more stuff can be removed:
@(XATargetsSrcFiles)item group<SetVsMonoAndroidRegistryKey/>MSBuild taskcreate-vsixandcreate-pkgprojectsXamarin.Android.Bindings.Before.targetsandXamarin.Android.Bindings.After.targetsXamarin.Android.Common.Before.targetsandXamarin.Android.Common.After.targetsRemoving these files may improve MSBuild project evaluation time, as they are currently running several
Exists()checks that always returnfalse.In the Xamarin.Android days, the XamarinVS Visual Studio extension layed down custom MSBuild targets files inside the Xamarin.Android installation to augment the build. This doesn't happen any more in .NET 6+, as they do not lay down files inside a .NET workload in
C:\Program Files\dotnet\packs.It wouldn't make sense to do so as Android workload updates would change the directory:
C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\35.0.7C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\35.0.39Note that I moved
runtime-entitlements.plisttobuild-tools/installers/as it is still used.