Remove call to CollectAssemblyFilesForArchive for Fast Deployment. #9650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
requested review from
jpobst
and removed request for
jonathanpeppers
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpobst
approved these changes
Jan 6, 2025
Contributor
jpobst
left a comment
jpobst
left a comment
There was a problem hiding this comment.
This seems good. One thing to consider for the future is if we can combine _BuildApkEmbed and _BuildApkFastDev, as ~95% of it is duplicated.
Commit 6b91b04 split up the BuildApk task into their own Tasks to improve build performance. In that change the call to `CollectAssemblyFilesForArchive` was a no-op if `EmbedAssembliesIntoApk` was set to `False`. However it was still being called in the `_BuildApkFastDev` target, even though it had a condition which would skip the target entirely if `EmbedAssembliesIntoApk` was `False`. So lets remove the call to `CollectAssemblyFilesForArchive` from `_BuildApkFastDev` completely. We can also remove the `EmbedAssemblies` property from the `CollectAssemblyFilesForArchive` task as it is no longer needed.
dellis1972
force-pushed
the
dev/dellis1972/fastdevremovecollect
branch
from
ac14713 to
8ca0581
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
added a commit
that referenced
this pull request
Jan 9, 2025
* main: Add `$(Nullable)` = `annotations` to projects using NRT annotations without NRT enabled. (#9660) [Xamarin.Android.Build.Tasks] Add %(NuGetPackage*) to TaskItems (#9559) Bump to dotnet/java-interop@ee47652d (#9659) [XABT] Remove <CollectAssemblyFilesForArchive/> from FastDeployment (#9650) [Mono.Android] Generate API docs for API level 35 (#9647) [java-runtime] simplify `mono.MonoPackageManager.LoadApplication()` (#9655) [Mono.Android] Bind Android API-Baklava DP2. (#9653) [build+macOS] Remove quarantine from OpenJDK installations (#9652)
grendello
added a commit
that referenced
this pull request
Jan 9, 2025
* dev/grendel/use-libc++: Add `$(Nullable)` = `annotations` to projects using NRT annotations without NRT enabled. (#9660) [Xamarin.Android.Build.Tasks] Add %(NuGetPackage*) to TaskItems (#9559) Bump to dotnet/java-interop@ee47652d (#9659) [XABT] Remove <CollectAssemblyFilesForArchive/> from FastDeployment (#9650) [Mono.Android] Generate API docs for API level 35 (#9647) [java-runtime] simplify `mono.MonoPackageManager.LoadApplication()` (#9655) [Mono.Android] Bind Android API-Baklava DP2. (#9653) [build+macOS] Remove quarantine from OpenJDK installations (#9652)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6b91b04 split up the BuildApk task into their own Tasks to improve build performance. In that change the call to
CollectAssemblyFilesForArchivewas a no-op ifEmbedAssembliesIntoApkwas set toFalse. However it was still being called in the_BuildApkFastDevtarget, even though it had a condition which would skip the target entirely ifEmbedAssembliesIntoApkwasFalse.So lets remove the call to
CollectAssemblyFilesForArchivefrom_BuildApkFastDevcompletely. We can also remove theEmbedAssembliesproperty from theCollectAssemblyFilesForArchivetask as it is no longer needed.