[build] setup a Prepare target for Xamarin.Android.sln #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://stackoverflow.com/questions/17709873/how-can-i-invoke-my-msbuild-target-when-msbuild-exe-starts-and-when-it-ends There is a convention where an MSBuild file named `Before.<SolutionName>.sln.targets` will get imported prior to a SLN file getting built. This enables us to import `PrepareWindows.targets` and enable `msbuild Xamarin.Android.sln /t:Prepare` to work appropriately. macOS/linux have remained unchanged, since `PrepareWindows.targets` currently only works for Windows. `make prepare` could be ported to MSBuild in the future.
|
@jonathanpeppers, |
Contributor
Not yet. It would be an interesting exercise, but it isn't required at this time. |
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
Context: https://stackoverflow.com/questions/17709873/how-can-i-invoke-my-msbuild-target-when-msbuild-exe-starts-and-when-it-ends There is a convention where an MSBuild file named `Before.<SolutionName>.sln.targets` will get imported prior to a SLN file getting built. This enables us to import `PrepareWindows.targets` and enable `msbuild Xamarin.Android.sln /t:Prepare` to work appropriately. macOS/Linux remain unchanged, since `PrepareWindows.targets` currently only works for Windows.
jonpryor
pushed a commit
that referenced
this pull request
Feb 11, 2022
Fixes: dotnet/java-interop#945 Changes: dotnet/java-interop@32635fd...7dc270d * dotnet/java-interop@7dc270db: [build] set $(ProduceReferenceAssemblyInOutDir)=True (#949) * dotnet/java-interop@f91b0770: [Xamarin.Android.Tools.Bytecode] Improve Kotlin metadata matching (#946)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
https://stackoverflow.com/questions/17709873/how-can-i-invoke-my-msbuild-target-when-msbuild-exe-starts-and-when-it-ends
There is a convention where an MSBuild file named
Before.<SolutionName>.sln.targetswill get imported prior to a SLNfile getting built. This enables us to import
PrepareWindows.targetsand enable
msbuild Xamarin.Android.sln /t:Prepareto workappropriately.
macOS/linux have remained unchanged, since
PrepareWindows.targetscurrently only works for Windows.
make preparecould be ported toMSBuild in the future.
Question
Do we need to look into
make preparefor the other platforms yet?If
make preparewas fully ported to MSBuild, you could run the samecommand to build on any platform:
I tested, and
xbuildlooks like it supports theBefore.<SolutionName>.sln.targetsconvention.