[trimming] remove $(NullabilityInfoContextSupport)
#9069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@sbomer is it possible this The apk regression tests failed: |
Member
|
@eiriktsarpalis would know better. It's possible the change still needs to go through dependency flow, since it was made recently. |
Member
Author
|
Ok, it might be we can merge this one after: We saw some minor size changes in that one as well. |
Context: dotnet/runtime#103970 Context: dotnet#9062 (comment) This setting was removed in dotnet/runtime#103970, so it doesn't do anything.
jonathanpeppers
force-pushed
the
NullabilityInfoContextSupport
branch
from
483ca17 to
db2f8bf
Compare
Member
Author
|
Ok, after the .NET SDK bump, it appears that removing |
grendello
added a commit
that referenced
this pull request
Jul 5, 2024
* main: [tests] verify trimmer warnings where appropriate (#9076) Bump to jbevain/cecil@8c123e1 (#9078) [trimming] remove `$(NullabilityInfoContextSupport)` (#9069) [build] Bump `$(XABuildToolsVersion)`=35 (#9071) [ci] Move PR build to shared pool (#8854) Use AsyncTask from xamarin-android-tools (#9017) Bump to dotnet/sdk@02c06d398a 9.0.100-preview.7.24351.1 (#9067) [trimming] use public `$(MetricsSupport)` property (#9068) [ci] Update resourceManagement.yml (#9070) Bump to dotnet/android-api-docs@c14203771a (#8992) [trimming] remove `$(_AggressiveAttributeTrimming)` by default (#9062)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#103970
Context: #9062 (comment)
This setting was removed in dotnet/runtime#103970, so it doesn't do anything.