[Xamarin.Android.Build.Tasks] PackageReference and AndroidUseLatestPlatformSdk do not work together #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This doesn't work. Need to rework it |
dellis1972
force-pushed
the
Bug59534
branch
from
4a3cb4d to
73f6685
Compare
…atformSdk do not work together Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59534 When using `PackageReference` with our system it run before `_SetLatestTargetFrameworkVersion`. As a result it always uses a `$(TargetFrameworkVersion)` of v2.3 or what ever the user defined in the project manually. So we need to make sure that `_SetLatestTargetFrameworkVersion` runs as part of the `PackageReference` target chain. Fortunately that chain is run as part of `ResolveNuGetPackageAssetsDependsOn`. As well as `_GetRestoreTargetFrameworksOutput`. So we just need to make sure that our target in run as part of that target chain in order to fix this issue. We also need to update a few NuGet specific properties to ensure that it uses the correct `TargetPlatformMoniker`. This is done via the `NuGetTargetMoniker`.
dellis1972
force-pushed
the
Bug59534
branch
from
73f6685 to
f4f1e98
Compare
Contributor
Author
|
Tests are in #846 |
Merged
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
Changes: http://github.com/xamarin/Java.Interop/compare/ff2714200107fb616828b9d1013f69605791d2ba...9a878f211c86bdd37cb71c5c461f85a0c1a1480d * dotnet/java-interop@9a878f21: [build] Properly implement "parent directory.override.props" (dotnet#300) (dotnet#873) * dotnet/java-interop@0c5d454c: [Java.Interop] fix .NET 6 linker warnings (dotnet#870) * dotnet/java-interop@8898bc14: [build] Import $(MSBuildProjectDirectory).override.props (dotnet#872) * dotnet/java-interop@d16b1e56: [build] Use GitInfo to generate $(Version) (dotnet#865) * dotnet/java-interop@2eb9ff26: [build] .NET 6 P7 Support (dotnet#869) Set `$(XamarinAndroidToolsDirectory)` for `external/Java.Interop` so that the Java.Interop build uses `external/xamarin-android-tools`.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 26, 2021
Changes: http://github.com/xamarin/Java.Interop/compare/ff2714200107fb616828b9d1013f69605791d2ba...b7982e423952a4c4afe0c33f36ac80eed7fa57a2 * dotnet/java-interop@b7982e42: Revert "[build] Use GitInfo to generate $(Version) (dotnet#865)" (dotnet#874) * dotnet/java-interop@9a878f21: [build] Properly implement "parent directory.override.props" (dotnet#300) (dotnet#873) * dotnet/java-interop@0c5d454c: [Java.Interop] fix .NET 6 linker warnings (dotnet#870) * dotnet/java-interop@8898bc14: [build] Import $(MSBuildProjectDirectory).override.props (dotnet#872) * dotnet/java-interop@d16b1e56: [build] Use GitInfo to generate $(Version) (dotnet#865) * dotnet/java-interop@2eb9ff26: [build] .NET 6 P7 Support (dotnet#869) Set `$(XamarinAndroidToolsDirectory)` for `external/Java.Interop` so that the Java.Interop build uses `external/xamarin-android-tools`.
jonpryor
added a commit
that referenced
this pull request
Aug 26, 2021
Changes: http://github.com/xamarin/Java.Interop/compare/ff2714200107fb616828b9d1013f69605791d2ba...b7982e423952a4c4afe0c33f36ac80eed7fa57a2 * dotnet/java-interop@b7982e42: Revert "[build] Use GitInfo to generate $(Version) (#865)" (#874) * dotnet/java-interop@9a878f21: [build] Properly implement "parent directory.override.props" (#300) (#873) * dotnet/java-interop@0c5d454c: [Java.Interop] fix .NET 6 linker warnings (#870) * dotnet/java-interop@8898bc14: [build] Import $(MSBuildProjectDirectory).override.props (#872) * dotnet/java-interop@d16b1e56: [build] Use GitInfo to generate $(Version) (#865) * dotnet/java-interop@2eb9ff26: [build] .NET 6 P7 Support (#869) Set `$(XamarinAndroidToolsDirectory)` for `external/Java.Interop` so that the Java.Interop build uses `external/xamarin-android-tools`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59534
When using
PackageReferencewith our system it run before_SetLatestTargetFrameworkVersion. As a result it alwaysuses a
$(TargetFrameworkVersion)of v2.3 or what ever theuser defined in the project manually.
So we need to make sure that
_SetLatestTargetFrameworkVersionruns as part of the
PackageReferencetarget chain. Fortunatelythat chain is run as part of
ResolveNuGetPackageAssetsDependsOn.As well as
_GetRestoreTargetFrameworksOutput.So we just need to make sure that our target in run as part of
that target chain in order to fix this issue.
We also need to update a few NuGet specific properties to ensure
that it uses the correct
TargetPlatformMoniker. This is donevia the
NuGetTargetMoniker.