[Xamarin.Android.Build.Tasks] fix net7.0 "out of support" message #8660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When .NET 9 ships, the .NET 7 Android workload will be out of support.
We already have this behavior setup, but unfortunately the error message
is wrong:
Microsoft.NET.EolTargetFrameworks.targets(38,5):
error NETSDK1202: The workload 'net6.0-android' is out of support and will not receive security updates in the future. Please refer to
https://aka.ms/maui-support-policy for more information about the support policy.
[MauiTest.csproj::TargetFramework=net7.0-android]
It says `net6.0-android`!
In a48a9c5, we hardcoded `net6.0` to align with the iOS team, but we
can use the `$(TargetFrameworkVersion)` property (removing `v`) so we
don't have to update this line every year.
I updated a test for this scenario.
mcumming
approved these changes
Jan 22, 2024
jonathanpeppers
commented
Jan 22, 2024
Member
Author
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
New test looks good:
grendello
approved these changes
Jan 25, 2024
jonathanpeppers
commented
Jan 25, 2024
| <ItemGroup> | ||
| <SdkSupportedTargetPlatformVersion Include="21.0" /> | ||
| <EolWorkload Include="net6.0-android" Url="https://aka.ms/maui-support-policy" /> | ||
| <EolWorkload Include="net$(TargetFrameworkVersion.TrimStart('vV'))-android" Url="https://aka.ms/maui-support-policy" /> |
Member
Author
There was a problem hiding this comment.
pjcollins
approved these changes
Jan 25, 2024
grendello
added a commit
that referenced
this pull request
Jan 26, 2024
* main: Bump to dotnet/installer@5680e93cb2 9.0.100-preview.2.24073.12 (#8666) $(AndroidPackVersionSuffix)=preview.2; net9 is 34.99.0.preview.2 (#8678) [Xamarin.Android.Build.Tasks] fix net7.0 "out of support" message (#8660) [ci] Use NuGetAuthenticate@1 (#8676)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When .NET 9 ships, the .NET 7 Android workload will be out of support. We already have this behavior setup, but unfortunately the error message is wrong:
It says
net6.0-android!In a48a9c5, we hardcoded
net6.0to align with the iOS team, but we can use the$(TargetFrameworkVersion)property (removingv) so we don't have to update this line every year.I updated a test for this scenario.