Skip to content

[ci] Don't emit warnings for normal CheckAdbTarget operations. #8568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpobst merged 1 commit into from
Dec 7, 2023
Merged

[ci] Don't emit warnings for normal CheckAdbTarget operations. #8568

jpobst merged 1 commit into from
Dec 7, 2023

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Dec 6, 2023 •
edited
Loading

Currently the start-emulator tasks emit 4 warnings for each invocation, related to the initial probing it does to see if an emulator is already running.

/Users/runner/work/1/s/build-tools/scripts/TestApks.targets(50,5): warning : * daemon not running; starting now at tcp:5037 [/Users/runner/work/1/s/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Emulator.csproj]
/Users/runner/work/1/s/build-tools/scripts/TestApks.targets(50,5): warning : * daemon started successfully [/Users/runner/work/1/s/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Emulator.csproj]
/Users/runner/work/1/s/build-tools/scripts/TestApks.targets(50,5): warning : adb: no devices/emulators found [/Users/runner/work/1/s/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Emulator.csproj]
/Users/runner/work/1/s/build-tools/scripts/TestApks.targets(50,5): warning :   Command /Users/runner/Library/Android/sdk/platform-tools/adb  shell getprop ro.build.version.sdk failed with exit code 1 [/Users/runner/work/1/s/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Emulator.csproj]

Write these messages as normal output instead of a warning.

Reduces CI reported warnings from 56 to 15.

@jpobst jpobst marked this pull request as ready for review December 6, 2023 23:02
@jpobst jpobst requested a review from jonpryor as a code owner December 6, 2023 23:02
@jpobst jpobst requested a review from pjcollins December 6, 2023 23:02
@jpobst jpobst merged commit abd6af7 into main Dec 7, 2023
@jpobst jpobst deleted the quieter-adb branch December 7, 2023 17:32
grendello added a commit that referenced this pull request Dec 7, 2023
@grendello
Merge branch 'main' into dev/grendel/blobs-in-lib
5f3598a 
* main:
  [ci] Don't emit warnings for normal `CheckAdbTarget` operations. (#8568)
  Localized file check-in by OneLocBuild Task (#8570)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pjcollins pjcollins pjcollins approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpobst @pjcollins