Skip to content

[d17-5] [Xamarin.Android.Build.Tasks] allow JDK 17 usage #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonpryor merged 1 commit into from
Aug 31, 2023
Merged

[d17-5] [Xamarin.Android.Build.Tasks] allow JDK 17 usage #8313

jonpryor merged 1 commit into from
Aug 31, 2023

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Aug 30, 2023

Context: #8309
Context: https://learn.microsoft.com/java/openjdk/download#openjdk-17

Classic Xamarin.Android apps appear to work with JDK-17, just by doing:

msbuild -r -bl -t:SignAndroidPackage -p:JavaSdkDirectory="C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot" -p:LatestSupportedJavaVersion=17.99

I see log messages calling a JDK 17 javac like:

_CompileJava:
C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot\bin\javac.exe -J-Dfile.encoding=UTF8 "@C:\Users\jopepper\AppData\Local\Temp\tmp119C.tmp" -target 1.8 -source 1.8

Update $(LatestSupportedJavaVersion) to allow usage of JDK 17.

@jonathanpeppers
[Xamarin.Android.Build.Tasks] allow JDK 17 usage
8b49491 
Context: dotnet#8309
Context: https://learn.microsoft.com/java/openjdk/download#openjdk-17

Classic Xamarin.Android apps appear to work with JDK-17, just by doing:

    msbuild -r -bl -t:SignAndroidPackage -p:JavaSdkDirectory="C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot" -p:LatestSupportedJavaVersion=17.99

I see log messages calling a JDK 17 `javac` like:

    _CompileJava:
    C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot\bin\javac.exe -J-Dfile.encoding=UTF8 "@C:\Users\jopepper\AppData\Local\Temp\tmp119C.tmp" -target 1.8 -source 1.8

Update `$(LatestSupportedJavaVersion)` to allow usage of JDK 17.
@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Aug 31, 2023

There is one test failure:

obj\Release should have no files.
Expected: <empty>
But was:  < "C:\a_work\1\a\TestRelease\08-31_17.47.23\temp\CleanBasicBindingLibraryclass-parse\obj\Release_XamarinBuildIsIncremental" >

This looks to be caused by a .targets file from XamarinVS:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\Xamarin.Sdk.targets

https://github.com/xamarin/XamarinVS/blob/main/src/MSBuild/Xamarin/Xamarin.Sdk.targets

<_XamarinBuildIsIncrementalFile>$(IntermediateOutputPath)\_XamarinBuildIsIncremental</_XamarinBuildIsIncrementalFile>
...
<WriteLinesToFile Lines="$(_XamarinBuildIsIncrementalFile)" File="$(_XamarinBuildIsIncrementalFile)" Condition="!Exists('$(_XamarinBuildIsIncrementalFile)')" ContinueOnError="true" />

The target seems questionable (would have benefitted from our code review), but I don't think .NET 6+ even imports this file, so we can probably ignore it?

@jonpryor
Copy link
Contributor

jonpryor commented Aug 31, 2023

@jonathanpeppers: the CleanBasicBindingLibrary("class-parse") is a "known bad" test and has been failing with that error for quite some time, e.g. from 7557f5d: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8199578&view=ms.vss-test-web.build-test-results-tab&runId=81691700&resultId=100097&paneView=history

obj\Release should have no files.
Expected: <empty>
But was:  < "C:\a_work\1\a\TestRelease\08-04_01.23.34\temp\CleanBasicBindingLibraryclass-parse\obj\Release_XamarinBuildIsIncremental" >

We can totally ignore this failure.

@jonpryor jonpryor merged commit 0f97e31 into dotnet:d17-5 Aug 31, 2023
@jonathanpeppers jonathanpeppers deleted the classic-jdk-17 branch August 31, 2023 21:41
jonathanpeppers added a commit that referenced this pull request Sep 1, 2023
@jonathanpeppers
[Xamarin.Android.Build.Tasks] allow JDK 17 usage (#8313)
9d23de4 
Context: #8309
Context: https://learn.microsoft.com/java/openjdk/download#openjdk-17

Classic Xamarin.Android apps appear to work with JDK-17, just by doing:

	msbuild -r -bl -t:SignAndroidPackage ^
	  -p:JavaSdkDirectory="C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot" ^
	  -p:LatestSupportedJavaVersion=17.99

I see log messages calling a JDK 17 `javac` like:

	_CompileJava:
	C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot\bin\javac.exe -J-Dfile.encoding=UTF8 "@C:\Users\jopepper\AppData\Local\Temp\tmp119C.tmp" -target 1.8 -source 1.8

Update `$(LatestSupportedJavaVersion)` to allow usage of JDK 17.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

@dellis1972 dellis1972 Awaiting requested review from dellis1972 dellis1972 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanpeppers @jonpryor