[tests] Switch to httpbin.org
#7556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`httpbingo.org` is returning the following error when we try to redirect. ``` Forbidden redirect URL. Be careful with this link. ``` To lets try to use `httpbin.org` directly instead.
pjcollins
approved these changes
Nov 15, 2022
Contributor
Author
|
Hmm getting a timeout now. But not on both tests... |
Contributor
|
I think the HTTP-504 can be ignored; it probably means that AzDO couldn't connect to github.com, cause (waves hands in the air) "reasons". The PR is green, and this is an improvement for our current tests. |
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 16, 2022
Context: 234cf2c Commit 234cf2c updated the `AndroidHandlerTestBase.Redirect_Without_Protocol_Works()` and `AndroidHandlerTestBase.Redirect_POST_With_Content_Works()` tests to use <httpbingo.org> to test HTTP redirect behavior. Recently, <httpbingo.org> started returning HTTP-403 for our redirection test, whereas we expected it to send HTTP-302: % curl -D - 'https://httpbingo.org/redirect-to?url=https://github.com/xamarin/xamarin-android' HTTP/2 403 access-control-allow-credentials: true access-control-allow-origin: * content-type: text/plain; charset=utf-8 x-content-type-options: nosniff date: Wed, 16 Nov 2022 15:38:02 GMT content-length: 51 server: Fly/5f2bf728 (2022-11-11) via: 2 fly.io fly-request-id: 01GJ0HE398V7F0BKFHY0D2N8YE-iad Forbidden redirect URL. Be careful with this link. This caused the `Redirect_Without_Protocol_Works()` and `Redirect_POST_With_Content_Works()` unit tests to start failing: System.Net.Http.HttpRequestException : Response status code does not indicate success: 403 (Forbidden). at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode () at Xamarin.Android.NetTests.AndroidHandlerTestBase.Redirect_POST_With_Content_Works () Update the tests to *stop* using <httpbingo.org> and instead use <httpbin.org>. This allows our tests to work as expected: % curl -D - 'https://httpbin.org/redirect-to?url=https://github.com/xamarin/xamarin-android' HTTP/2 302 date: Wed, 16 Nov 2022 15:38:28 GMT content-type: text/html; charset=utf-8 content-length: 0 location: https://github.com/xamarin/xamarin-android server: gunicorn/19.9.0 access-control-allow-origin: * access-control-allow-credentials: true
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 16, 2022
Context: 234cf2c Commit 234cf2c updated the `AndroidHandlerTestBase.Redirect_Without_Protocol_Works()` and `AndroidHandlerTestBase.Redirect_POST_With_Content_Works()` tests to use <httpbingo.org> to test HTTP redirect behavior. Recently, <httpbingo.org> started returning HTTP-403 for our redirection test, whereas we expected it to send HTTP-302: % curl -D - 'https://httpbingo.org/redirect-to?url=https://github.com/xamarin/xamarin-android' HTTP/2 403 access-control-allow-credentials: true access-control-allow-origin: * content-type: text/plain; charset=utf-8 x-content-type-options: nosniff date: Wed, 16 Nov 2022 15:38:02 GMT content-length: 51 server: Fly/5f2bf728 (2022-11-11) via: 2 fly.io fly-request-id: 01GJ0HE398V7F0BKFHY0D2N8YE-iad Forbidden redirect URL. Be careful with this link. This caused the `Redirect_Without_Protocol_Works()` and `Redirect_POST_With_Content_Works()` unit tests to start failing: System.Net.Http.HttpRequestException : Response status code does not indicate success: 403 (Forbidden). at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode () at Xamarin.Android.NetTests.AndroidHandlerTestBase.Redirect_POST_With_Content_Works () Update the tests to *stop* using <httpbingo.org> and instead use <httpbin.org>. This allows our tests to work as expected: % curl -D - 'https://httpbin.org/redirect-to?url=https://github.com/xamarin/xamarin-android' HTTP/2 302 date: Wed, 16 Nov 2022 15:38:28 GMT content-type: text/html; charset=utf-8 content-length: 0 location: https://github.com/xamarin/xamarin-android server: gunicorn/19.9.0 access-control-allow-origin: * access-control-allow-credentials: true
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 16, 2022
* main: Bump to xamarin/android-api-docs@814988c (dotnet#7557) [tests] Switch to `httpbin.org` (dotnet#7556)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpbingo.orgis returning the following error when we try to redirect.To lets try to use
httpbin.orgdirectly instead.