[api-compatibility] Fix warnings and ignored errors #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR builds such as macOS+xbuild PR Builder build 1365 are
emitting an error from
mono-api-info, which isn't surfaced as anerror (hence the builds are still green):
This error is raised when processing
bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Xamarin.Android.NUnitLite.dllbecause
$(MONO_API_INFO_LIB_DIRS)contains-L .../MonoAndroid/v8.0, but the PR builds are building v7.1, notv8.0, and thus
Mono.Android.dllisn't in a directory which is found.$(MONO_API_INFO_LIB_DIRS)is wrong in turn becausemake run-api-compatibility-testswas overriding$(STABLE_FRAMEWORKS)to include frameworks which the PR builddoesn't build.
Update
make run-api-compatibility-testsso that$(STABLE_FRAMEWORKS)isn't overridden. This will allowxamarin-android-api-compatibilityto probe the frameworks based onwhat's present, and construct
$(MONO_API_INFO_LIB_DIRS)accordingly.Additionally, xamarin-android master builds such as build #538
were also failing in an unreported manner:
The cause for this is that
OpenTK-1.0.dllis built into theMonoAndroid/$(AndroidLatestFrameworkVersion)framework directory,and
Configuration.propswas setting$(AndroidLatestFrameworkVersion)to v7.1 (API-25).Update
$(AndroidLatestFrameworkVersion)to v8.0, and$(AndroidLatestApiLevel)to 26.