[Xamarin.Android.Build.Tasks] run a Clean if the project path changes. #7476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I really like this idea, this also would fix: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1591025
Can we add a test? Maybe just move a folder and make sure a bunch of targets run?
Minor nitpick: the title says "Clean", but it doesn't really run -t:Clean? Should we say "rerun all targets" instead?
jonathanpeppers
approved these changes
Oct 24, 2022
dellis1972
force-pushed
the
Issue6924
branch
3 times, most recently
from
b57f19c to
5292200
Compare
dellis1972
force-pushed
the
Issue6924
branch
3 times, most recently
from
fee5870 to
b225cae
Compare
Fixes dotnet#6924 If the user moves the project to another location on the hard drive the build will fail with errors such as. ``` APT2126 file not found. Foo.Foo C:\Foo.Foo\obj\Debug\net6.0-android\lp\122\jl\res\values\attr.xml 1 ``` To work around this we should place the `$(MSBuildProjectFullPath)` value in the `_PropertyCacheItems` ItemGroup. This will trigger a Clean if it changes.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 14, 2022
* main: [ci] Enable CodeQL on nightly build (dotnet#7522) Bump to xamarin/Java.Interop/main@984711a (dotnet#7545) [Xamarin.Android.Build.Tasks] Timing.xml & `android:exported="true"` (dotnet#7551) [Xamarin.Android.Build.Tasks] run a Clean if the project path changes. (dotnet#7476)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6924
If the user moves the project to another location on the hard drive the build will fail with errors such as.
To work around this we should place the
$(MSBuildProjectFullPath)value in the_PropertyCacheItemsItemGroup. This will trigger a Clean if it changes.