[Xamarin.Android.Build.Tasks] Fix up ToJniName to use cache.
#7460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ManifestDocument class has a few instances of `ToJniName` that are not using the `cache` overload. Using the `cache` version should be faster, so lets try to use that :).
jonathanpeppers
approved these changes
Oct 13, 2022
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Going to just restart a couple test lanes.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 17, 2022
* main: [Mono.Android] nullability for AndroidMessageHandler.RequestNeedsAuthorization (dotnet#7454) [Xamarin.Android.Build.Tasks] Fix up `ToJniName` to use `cache`. (dotnet#7460) Bump to xamarin/android-api-docs@52d85154 (dotnet#7459) Bump to xamarin/xamarin-android-tools/main@9f56dec (dotnet#7456)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 18, 2022
* main: [Mono.Android] nullability for AndroidMessageHandler.RequestNeedsAuthorization (dotnet#7454) [Xamarin.Android.Build.Tasks] Fix up `ToJniName` to use `cache`. (dotnet#7460) Bump to xamarin/android-api-docs@52d85154 (dotnet#7459) Bump to xamarin/xamarin-android-tools/main@9f56dec (dotnet#7456)
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 16, 2022
Context: dotnet/java-interop@b81cfbb The `ManifestDocument` class has a few instances of `ToJniName` that are not using the `cache` overload. Using the `cache` version should be faster, so lets try to use that :) This required plumbing the `cache` variable through another few methods as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ManifestDocument class has a few instances of
ToJniNamethat are not using thecacheoverload. Using thecacheversion should be faster, so lets try to use that :).