[Xamarin.Android.Build.Tasks] Multidex & $(Configuration)+spaces (#725) #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…net#725) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58134 We did a ton of stuff to get multidex working correctly on Windows in commit 6829b7d. However it seems that if there are spaces in the path on macOS, we get similar problems. The solution is to add single quotes around the list of `.jar` files when calling `MainDexListBuilder`. That seems pretty logical. But... it breaks it on Windows (sigh). Because on Windows if we add the single quotes, it stops working. So we have to conditionally add the single quotes around the list of jar files. Note this only applies when we call the `MainDexListBuilder`. The single quotes seem to work ok when calling proguard.. Weird. This commit also adds a unit test for this. However we needed to be able to change the names of the Configurations "Debug", "Release". So contructor arguments have been added to allow them to be overridden. These will default to "Debug" and "Release" so that existing tests will work as expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58134
We did a ton of stuff to get multidex working correctly on Windows
in commit 6829b7d. However it seems that if there are spaces in the
path on macOS, we get similar problems.
The solution is to add single quotes around the list of
.jarfileswhen calling
MainDexListBuilder. That seems pretty logical.But... it breaks it on Windows (sigh). Because on Windows if we add
the single quotes, it stops working.
So we have to conditionally add the single quotes around the list
of jar files. Note this only applies when we call the
MainDexListBuilder.The single quotes seem to work ok when calling proguard..
Weird.
This commit also adds a unit test for this. However we needed to be
able to change the names of the Configurations "Debug", "Release".
So contructor arguments have been added to allow them to be overridden.
These will default to "Debug" and "Release" so that existing tests will
work as expected.