Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Aug 16, 2022

Changes: dotnet/java-interop@a5756ca...e31d9c6

Supports usage of new [ObsoletedOSPlatformAttribute]. Changes needed:

  • Update Mono.Android.targets to pass lang-feature=obsoleted-platform-attributes to generator when building for .NET 7+
  • Update acceptable-breakages-vReference-net7.0.txt to account for removing existing [Obsolete] attributes in favor of the new ones, for .NET 7+ only

@jpobst jpobst changed the title Test JI 1026. Bump to xamarin/java.interop@e31d9c62 Aug 23, 2022
@jpobst jpobst marked this pull request as ready for review August 23, 2022 22:56
@jpobst jpobst requested a review from jonpryor as a code owner August 23, 2022 22:56
@jonpryor jonpryor merged commit 4da2792 into main Aug 24, 2022
@jonpryor jonpryor deleted the test-ji-1026 branch August 24, 2022 13:34
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 24, 2022
* main:
  Bump to dotnet/installer@84d26a0 7.0.100-rc.2.22419.24 (dotnet#7294)
  Bump to xamarin/java.interop/main@e31d9c62 (dotnet#7266)
jonathanpeppers pushed a commit that referenced this pull request Aug 24, 2022
Fixes: #7234

Changes: dotnet/java-interop@a5756ca...e31d9c6

  * dotnet/java-interop@e31d9c62: Context: #7285 (comment) (#1029)
  * dotnet/java-interop@d3ea180c: [generator] Add support for `[ObsoletedOSPlatform]` (#1026)
  * dotnet/java-interop@6d1ae4ee: [generator] Remove [Obsolete] style compatibility hacks. (#1025)
  * dotnet/java-interop@440c05ee: [generator] Refactor logic for applying [Obsolete] attributes (#1024)
  * dotnet/java-interop@9b1d3ab7: [Localization] Import translated resx files (#1018)

`generator` can now emit `[ObsoletedOSPlatformAttribute]`.  Requires:

  - Update `Mono.Android.targets` to pass
    `lang-feature=obsoleted-platform-attributes` to `generator` when
    building for .NET 7+

  - Update `acceptable-breakages-vReference-net7.0.txt` to account
    for removing existing `[Obsolete]` attributes in favor of the new
    ones, for .NET 7+ only
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 24, 2022
* mm-runtime:
  Bump to dotnet/installer@84d26a0 7.0.100-rc.2.22419.24 (dotnet#7294)
  Bump to xamarin/java.interop/main@e31d9c62 (dotnet#7266)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants