Skip to content

Test JI #1024. #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpobst wants to merge 1 commit into from
Closed

Test JI #1024. #7240

jpobst wants to merge 1 commit into from

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Aug 8, 2022

No description provided.

@jpobst jpobst mentioned this pull request Aug 8, 2022
Merged
@jonpryor
Copy link
Contributor

jonpryor commented Aug 11, 2022

I'm not sure why so many tests are failing on this PR. Could the Java.Interop bump really be responsible for these build failures? Consider AndroidAddKeepAlives(False,False,False,False):

/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/dotnet build /Users/runner/work/1/a/TestRelease/08-08_22.18.51/temp/AndroidAddKeepAlivesFalseFalseFalseFalse/UnnamedProject.csproj /t:Build,SignAndroidPackage /noconsolelogger "/flp1:LogFile=/Users/runner/work/1/a/TestRelease/08-08_22.18.51/temp/AndroidAddKeepAlivesFalseFalseFalseFalse/build.log;Encoding=UTF-8;Verbosity=diagnostic" -nodeReuse:false @"/Users/runner/work/1/a/TestRelease/08-08_22.18.51/temp/AndroidAddKeepAlivesFalseFalseFalseFalse/project.rsp"
MSBuild version 17.4.0-preview-22403-01+4e58a8330 for .NET
MSBUILD : error MSB1008: Only one project can be specified.
    Full command line: '/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/sdk/7.0.100-rc.1.22407.1/MSBuild.dll -maxcpucount -verbosity:m -restore -consoleloggerparameters:Summary --property:_DisableParallelAot=true /Users/runner/work/1/a/TestRelease/08-08_22.18.51/temp/AndroidAddKeepAlivesFalseFalseFalseFalse/UnnamedProject.csproj /t:Build,SignAndroidPackage /noconsolelogger /flp1:LogFile=/Users/runner/work/1/a/TestRelease/08-08_22.18.51/temp/AndroidAddKeepAlivesFalseFalseFalseFalse/build.log;Encoding=UTF-8;Verbosity=diagnostic -nodeReuse:false  /p:BuildingInsideVisualStudio=True  /p:BuildingOutOfProcess=true  /p:AndroidSdkDirectory="/Users/runner/Library/Android/sdk"   /p:JavaSdkDirectory="/Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.16-8/x64/Contents/Home/"   /bl:"/Users/runner/work/1/a/TestRelease/08-08_22.18.51/temp/AndroidAddKeepAlivesFalseFalseFalseFalse/msbuild.binlog" -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/sdk/7.0.100-rc.1.22407.1/dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/sdk/7.0.100-rc.1.22407.1/dotnet.dll'
  Switches appended by response files:
Switch:  /p:BuildingInsideVisualStudio=True

I do not understand how the Java.Interop bump could cause such an error.

@jpobst
Copy link
Contributor Author

jpobst commented Aug 11, 2022 •
edited
Loading

I reran a full CI build for this and it's green:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6545224&view=results

I am not sure why this PR is still showing the original CI status.

Anyways, the main point was to run ApiCompat to ensure no [Obsolete] attributes had changed. Given that it passed, I think the JI change is good to go.

@jpobst jpobst closed this Aug 11, 2022
@jpobst jpobst deleted the test-ji-1024 branch August 11, 2022 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers jonathanpeppers will be requested when the pull request is marked ready for review jonathanpeppers is a code owner

@grendello grendello Awaiting requested review from grendello grendello will be requested when the pull request is marked ready for review grendello is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpobst @jonpryor