[main] Update dependencies from dotnet/installer #7170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…220714.7 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-preview.7.22361.1 -> To Version 7.0.100-rc.1.22364.7 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22354.1 -> To Version 7.0.100-1.22362.3 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
jonpryor and
pjcollins
as code owners
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 14, 2022
Context: https://github.com/xamarin/xamarin-android/tree/release/7.0.1xx-preview7 Context: dotnet#7170 We branched for .NET 7 Preview 7, and there is already a Maestro bump for .NET 7 RC 1. Let's update xamarin-android/main's version number.
Companion to dotnet/linker#2856 * Update src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets * Remove more usages of TrimMode * Update linker versions manually Co-authored-by: Jonathan Peppers <[email protected]>
This was causing an .apk size regression. I admit the code that was here needs updated, but we should do it in a way that `.apk` sizes do not regress. Potentially update AndroidX libraries in tests? And then we can rely on the default behavior?
jonpryor
pushed a commit
that referenced
this pull request
Jul 15, 2022
Context: https://github.com/xamarin/xamarin-android/tree/release/7.0.1xx-preview7 Context: #7170 We branched for .NET 7 Preview 7, and there is already a Maestro bump for .NET 7 RC 1. Let's update xamarin-android/main's version number.
…220718.2 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-preview.7.22361.1 -> To Version 7.0.100-rc.1.22368.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100 From Version 7.0.100-1.22354.1 -> To Version 7.0.100-1.22365.1 (parent: Microsoft.Dotnet.Sdk.Internal
GitHub desktop somehow messed this up, and didn't commit this file.
Member
|
Ok, I'm confused how this test is failing on only some lanes:
|
Member
|
Ok, maybe the failing ones are Xamarin.Android (not .NET 7) and something is broken in main. |
dellis1972
approved these changes
Jul 20, 2022
Member
|
@jonathanpeppers As a workaround for the size increase, you can try adding |
jonathanpeppers
approved these changes
Jul 22, 2022
jonathanpeppers
deleted the
darc-main-1a7fcdae-fd29-44ca-936b-bdbc39f54705
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer