[build] Use local .NET preview to build net7.0 #7022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
pjcollins
force-pushed
the
use-bin-dotnet
branch
4 times, most recently
from
e603056 to
4e6a589
Compare
grendello
approved these changes
May 24, 2022
dellis1972
approved these changes
May 24, 2022
jonathanpeppers
approved these changes
May 24, 2022
simonrozsival
pushed a commit
to simonrozsival/xamarin-android
that referenced
this pull request
May 31, 2022
) Removes the need to have a .NET 7 preview installed globally to build. A .NET 6 install is required to build and run xaprepare, which will provision a .NET 7 preview build used for further building and testing. Instructions to build on macOS remain unchanged: make prepare make all or make jenkins Instructions to build on Windows have been updated: dotnet msbuild -t:Prepare Xamarin.Android.sln dotnet-local.cmd -t:PackDotNet Xamarin.Android.sln -m:1 The `dotnet msbuild` command is recommended as it will not attempt a restore. This will allow the `Prepare` target to run against a .NET 6 install, even though `Xamarin.Android.sln` contains projects that target net7.0. Otherwise, attempts to dotnet build any target belonging to `Xamarin.Android.sln` with .NET 6 will fail during restore: Project "C:\Users\Peter\source\pj\xamarin-android\Xamarin.Android.sln" on node 1 (Restore target(s)). ValidateSolutionConfiguration: Building solution configuration "Debug|AnyCPU". _GetAllRestoreProjectPathItems: Determining projects to restore... Project "C:\Users\Peter\source\pj\xamarin-android\Xamarin.Android.sln" (1) is building "C:\Users\Peter\source\pj\xamarin-android\src\Microsoft.Android.Sdk.ILLink\Microsoft.Android.Sdk.ILLink.csproj" (11:4) on node 1 (_GenerateRestoreGraphProjectEntry target(s)). C:\Program Files\dotnet\sdk\6.0.300\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(144,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 7.0. Either target .NET 6.0 or lower, or use a version of the .NET SDK that supports .NET 7.0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to have a .NET 7 preview installed globally to build.
A .NET 6 install is required to build and run xaprepare, which will
provision a .NET 7 preview build used for further building and testing.
Instructions to build on macOS remain unchanged:
or
Instructions to build on Windows have been updated:
The
dotnet msbuildcommand is recommended as it will not attempt arestore. This will allow the
Preparetarget to run against a .NET 6install, even though
Xamarin.Android.slncontains projects that targetnet7.0. Otherwise, attempts to dotnet build any target belonging to
Xamarin.Android.slnwith .NET 6 will fail during restore: