[Xamarin.Android.Build.Tests] Fix the tests to pick up the correct runtime. #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
build |
1 similar comment
Contributor
Author
|
build |
Contributor
Author
|
This build is passing ! We just get the following error "Build step 'Upload artifacts to Microsoft Azure Storage' marked build as failure" :'( |
dellis1972
force-pushed
the
fixtestrun
branch
4 times, most recently
from
f37587e to
536785b
Compare
…ntime. There was a change (05aebd7) in the naming of the libmono-android.*.so files. It used to be that the name included the abi. But now we just get files like libmono-android.debug.d.so libmono-android.release.so These were not picking up the right runtime info in the tests. They were getting an arch of 'd' because we expected files like libmono-android.release.armeabi-v7a.so So we need to update the ProjectBuilder which loads the data to take this into account and use the Parent directory name for the abi and to ignore the .d.so files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change (05aebd7) in the naming of the libmono-android.*.so files.
It used to be that the name included the abi. But now we just get
files like
These were not picking up the right runtime info in the tests. They
were getting an arch of 'd' because we expected files like
So we need to update the ProjectBuilder which loads the data to
take this into account and use the Parent directory name for the
abi and to ignore the .d.so files.