try to use jdk 11 for device tests #6033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Jun 21, 2021
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I kind of think we should merge this to get CI green.
Then revisit next week what we should do?
Since 5da92bd we are seeing the on device tests fail with the following error. error JAVAC0000: java.lang.AssertionError: annotationType() : unrecognized Attribute name MODULE (class com.sun.tools.javac.util.SharedNameTable$NameImpl) This suggests that AP 31 requires JDK 11 in order to compile. So lets bump the version which we use for the on device tests for now, until we can figure out what do actually do.
dellis1972
force-pushed
the
usejdk11fordevicetests
branch
from
62d106d to
3f35fef
Compare
jonathanpeppers
pushed a commit
that referenced
this pull request
Jun 22, 2021
Since 5da92bd, we are seeing the on device tests fail with the following error. error JAVAC0000: java.lang.AssertionError: annotationType() : unrecognized Attribute name MODULE (class com.sun.tools.javac.util.SharedNameTable$NameImpl) This suggests that API 31 requires JDK 11 in order to compile. So lets bump the version which we use for the on device tests for now, until we can figure out what do actually do.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 16, 2021
This reverts commit d14f4a2.
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
Since 5da92bd, we are seeing the on device tests fail with the following error. error JAVAC0000: java.lang.AssertionError: annotationType() : unrecognized Attribute name MODULE (class com.sun.tools.javac.util.SharedNameTable$NameImpl) This suggests that API 31 requires JDK 11 in order to compile. So lets bump the version which we use for the on device tests for now, until we can figure out what do actually do.
jonpryor
pushed a commit
that referenced
this pull request
Aug 26, 2021
Since 5da92bd, we are seeing the on device tests fail with the following error. error JAVAC0000: java.lang.AssertionError: annotationType() : unrecognized Attribute name MODULE (class com.sun.tools.javac.util.SharedNameTable$NameImpl) This suggests that API 31 requires JDK 11 in order to compile. So lets bump the version which we use for the on device tests for now, until we can figure out what do actually do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5da92bd we are seeing the on device tests fail with the following error.
This suggests that AP 31 requires JDK 11 in order to compile.
So lets bump the version which we use for the on device tests for now,
until we can figure out what do actually do.