[One .NET] remove EnableWorkloadResolver.sentinel #5909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
remove-enableworkloadresolver.sentinel
branch
from
3b0ea8e to
24311f7
Compare
Member
Author
|
I think we actually need a newer preview 5 build for this: |
This feature flag is now on by default in .NET 6.0.100-preview.4.21253.14 and higher. We should stop generating `EnableWorkloadResolver.sentinel`, as it strongly ties our installers to a specific version of the .NET SDK.
jonathanpeppers
force-pushed
the
remove-enableworkloadresolver.sentinel
branch
from
24311f7 to
ad7ca58
Compare
Member
Author
|
Only test failures are related to And this one seems like it is maybe a random issue: |
pjcollins
approved these changes
May 10, 2021
jonathanpeppers
added a commit
to jonathanpeppers/maui
that referenced
this pull request
May 13, 2021
Context: dotnet/android#5909 This file is no longer needed in .NET 6 Preview 4 and higher. We should stop creating it now.
18 tasks
rmarinho
pushed a commit
to dotnet/maui
that referenced
this pull request
May 13, 2021
Context: dotnet/android#5909 This file is no longer needed in .NET 6 Preview 4 and higher. We should stop creating it now.
lytico
pushed a commit
to lytico/maui
that referenced
this pull request
May 15, 2021
Context: dotnet/android#5909 This file is no longer needed in .NET 6 Preview 4 and higher. We should stop creating it now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature flag is now on by default in .NET 6.0.100-preview.4.21253.14 and higher.
We should stop generating
EnableWorkloadResolver.sentinel, as it strongly ties our installers to a specific version of the .NET SDK.