[One .NET] default $(SuppressTrimAnalysisWarnings) to true #5781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#5751 After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings. This is because of: dotnet/sdk#16327 We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these warnings for now. We should continue to use `TrimMode=link`, as that is the behavior Xamarin developers get today.
dellis1972
approved these changes
Mar 25, 2021
Contributor
As explained in the issue that code is now dead because it's exactly what sdk does for everyone (see https://github.com/dotnet/sdk/blob/main/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.ILLink.targets#L193) |
Member
Author
I see now @marek-safar, thanks. I'll remove |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5751
After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:
dotnet/sdk#16327
We need to default
$(SuppressTrimAnalysisWarnings)to ignore thesewarnings for now.
We should continue to use
TrimMode=link, as that is the behaviorXamarin developers get today.