[illink] Don't initialize managed peer #5444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Jan 11, 2021
Context: dotnet/android#5400 Context: dotnet/android#5444 Don't call `ManagedPeer.Init()` from the `JniRuntime` constructor when `XA_JI_EXCLUDE` is `#define`d. The presence of `ManagedPeer.Init()` requires that *all* Xamarin.Android apps contain `System.Linq.Expressions` types after linking, because `ManagedPeer.Construct()` calls `JniEnvironment.Runtime.MarshalMemberBuilder.CreateConstructActivationPeerFunc()` which pulls in all the `System.Linq.Expressions` infrastructure. Currently, *nothing* requires `ManagedPeer` *at all*; Java.Interop- "style" "Java Activation" (8c83f64) is not used outside of unit tests. Consequently, there is no need to pay the cost of System.Linq.Expressions within all Xamarin.Android apps. Wrap the `ManagedPeer.Init()` invocation with `XA_JI_EXCLUDE` so that the Xamarin.Android build of `Java.Interop.dll` (893562c) *excludes* the `ManagedPeer.Init()` invocation. This allows every Xamarin.Android app to link out System.Linq.Expressions, unless the app is otherwise using that namespace. `XA_JI_EXCLUDE` is intended to be set by `$(JavaInteropDefineConstants)` MSBUild property within the optional file `bin/Build$(Configuration)/XAConfig.props`, which the xamarin-android build will create before building `Java.Interop.csproj`. Cleanup the `src/Java.Interop` source code to remove use of the `XA_INTEGRATION` symbol. This symbol is no longer of use, and now only adds noise.
radekdoulik
force-pushed
the
pr-disable-managed-peer-init
branch
from
d28a78c to
fa92b24
Compare
radekdoulik
requested review from
dellis1972,
grendello,
jonathanpeppers and
jonpryor
as code owners
grendello
approved these changes
Jan 12, 2021
radekdoulik
force-pushed
the
pr-disable-managed-peer-init
branch
from
20c1bb8 to
095fc6e
Compare
Context: dotnet#5400 Context: dotnet/java-interop#761 Generate `XAConfig.props` file in Java.Interop to define `XA_JI_EXCLUDE` compilation constant. The generated file contains properties set for Java.Interop by XA. So far it is only setting one property, and thus doesn't necessarily be generated. I still wanted to be written by `xaprep`, plus it might be handy in future for other configuration. The currently set `JavaInteropDefineConstants` property is going to be used to disable `ManagedPeer` initialization. We don't really use `ManagedPeer` today and it is duplicating functionality of `ConstructorBuilder` class. The unwanted effect of having it in JI is that it is pulling in System.Linq.Expressions, which greatly increase assemblies size after linking. The size reduction for simple XA app is cca 135kbytes of compressed size. Size difference in bytes ([*1] apk1 only, [*2] apk2 only): - 27 assemblies/Mono.Android.dll - 30 assemblies/System.Collections.Concurrent.dll - 989 assemblies/System.Linq.dll - 2,930 assemblies/Java.Interop.dll - 4,514 assemblies/System.Collections.dll *1 - 4,874 assemblies/System.ObjectModel.dll *1 - 7,987 assemblies/System.Private.CoreLib.dll - 115,284 assemblies/System.Linq.Expressions.dll *1 Summary: - 136,635 Assemblies -14.87% (of 918,689) - 139,506 Package size difference -1.79% (of 7,780,819)
radekdoulik
force-pushed
the
pr-disable-managed-peer-init
branch
from
095fc6e to
a04ba26
Compare
Contributor
|
Current This happens because commit 130905e added the Java.Interop unit tests to the Mono.Android-Tests app, and the Java.Interop unit tests do use There are thus two paths forward:
I'm of course partial to (2). How do we remove the
namespace Java.Interop {
partial class JniRuntime {
partial abstract class JniValueManager {
public abstract void ActivatePeer (JniObjectReference reference, ConstructorInfo peerConstructor, object[]? constructorArgumentValues);
}
}
}Within the Java.Interop repo,
Once JniEnvironment.Runtime.ValueManager.ActivatePeer (new JniObjectReference (n_self), ctor, pvalues);This should allow |
radekdoulik
added a commit
that referenced
this pull request
Jan 21, 2021
Context: #5444 This allows us to remove SLE dependency and save cca 15% of assembly size. Size difference of BuildReleaseArm64False on net6: Size difference in bytes ([*1] apk1 only, [*2] apk2 only): + 96 assemblies/Mono.Android.dll - 331 assemblies/System.Collections.Concurrent.dll - 907 assemblies/Java.Interop.dll - 1,003 assemblies/System.Linq.dll - 3,856 assemblies/System.ObjectModel.dll *1 - 4,496 assemblies/System.Collections.dll *1 - 7,824 assemblies/System.Private.CoreLib.dll - 115,284 assemblies/System.Linq.Expressions.dll *1 Summary: - 133,605 Assemblies -15.33% (of 871,776)
Member
Author
|
Superseded by #5530 |
radekdoulik
added a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Jan 22, 2021
Context: dotnet#5444 This allows us to remove SLE dependency and save cca 15% of assembly size. Size difference of BuildReleaseArm64False on net6: Size difference in bytes ([*1] apk1 only, [*2] apk2 only): + 96 assemblies/Mono.Android.dll - 331 assemblies/System.Collections.Concurrent.dll - 907 assemblies/Java.Interop.dll - 1,003 assemblies/System.Linq.dll - 3,856 assemblies/System.ObjectModel.dll *1 - 4,496 assemblies/System.Collections.dll *1 - 7,824 assemblies/System.Private.CoreLib.dll - 115,284 assemblies/System.Linq.Expressions.dll *1 Summary: - 133,605 Assemblies -15.33% (of 871,776)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5400
Context: dotnet/java-interop#761
Generate
XAConfig.propsfile in Java.Interop to defineXA_JI_EXCLUDEcompilation constant.
The generated file contains properties set for Java.Interop by XA. So
far it is only setting one property, and thus doesn't necessarily be
generated. I still wanted to be written by
xaprep, plus it might behandy in future for other configuration.
The currently set
JavaInteropDefineConstantsproperty is usedto disable
ManagedPeerinitialization.We don't really use
ManagedPeertoday and it is duplicatingfunctionality of
ConstructorBuilderclass. The unwanted effect ofhaving it in JI is that it is pulling in
System.Linq.Expressions, whichgreatly increase assemblies size after linking.
The size reduction for simple XA app is cca 135kbytes of compressed
size.