Bump to mono/2017-02/5a3b524b, Java.Interop/master/bc58e159 #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary purpose is to bump to cecil/mono-2017-02/6721da21, which contains a `.pdb` file reader fix.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 16, 2017
PR builds such as [**macOS+xbuild PR Builder** build 1365][0] are emitting an error from `mono-api-info`, which isn't surfaced as an error (hence the builds are still green): [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-pr-builder/1365/consoleText [ERROR] FATAL UNHANDLED EXCEPTION: Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' at Mono.Cecil.BaseAssemblyResolver.Resolve (Mono.Cecil.AssemblyNameReference name, Mono.Cecil.ReaderParameters parameters) [0x0015e] in …/xamarin-android/external/Java.Interop/external/cecil/Mono.Cecil/BaseAssemblyResolver.cs:161 This error is raised when processing `bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Xamarin.Android.NUnitLite.dll` because [`$(MONO_API_INFO_LIB_DIRS)`][1] contains `-L .../MonoAndroid/v8.0`, but the PR builds are building v7.1, *not* v8.0, and thus `Mono.Android.dll` isn't in a directory which is found. [1]: https://github.com/xamarin/xamarin-android-api-compatibility/blob/49b5789/Makefile#L26-L29 `$(MONO_API_INFO_LIB_DIRS)` is wrong in turn because `make run-api-compatibility-tests` was overriding `$(STABLE_FRAMEWORKS)` to include frameworks which the PR build doesn't build. Update `make run-api-compatibility-tests` so that `$(STABLE_FRAMEWORKS)` isn't overridden. This will allow `xamarin-android-api-compatibility` to probe the frameworks based on what's present, and construct `$(MONO_API_INFO_LIB_DIRS)` accordingly. Additionally, xamarin-android master builds such as [build dotnet#538][2] were also failing in an unreported manner: [2]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/538/consoleText Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: '…/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v8.0/OpenTK-1.0.dll, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' at Mono.Cecil.BaseAssemblyResolver.Resolve (Mono.Cecil.AssemblyNameReference name, Mono.Cecil.ReaderParameters parameters) [0x00164] in <336971fa838f4b15a2a3a9274b113045>:0 at CorCompare.AssemblyCollection.LoadAssembly (System.String assembly) [0x0002a] in <d46deda6cbab4407bacfbd3b1ee45bd0>:0 Cannot load assembly file …/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v8.0/OpenTK-1.0.dll The cause for this is that `OpenTK-1.0.dll` is built into the `MonoAndroid/$(AndroidLatestFrameworkVersion)` framework directory, and `Configuration.props` was setting `$(AndroidLatestFrameworkVersion)` to v7.1 (API-25). Update `$(AndroidLatestFrameworkVersion)` to v8.0, and `$(AndroidLatestApiLevel)` to 26.
atsushieno
pushed a commit
that referenced
this pull request
Aug 16, 2017
PR builds such as [**macOS+xbuild PR Builder** build 1365][0] are emitting an error from `mono-api-info`, which isn't surfaced as an error (hence the builds are still green): [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-pr-builder/1365/consoleText [ERROR] FATAL UNHANDLED EXCEPTION: Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' at Mono.Cecil.BaseAssemblyResolver.Resolve (Mono.Cecil.AssemblyNameReference name, Mono.Cecil.ReaderParameters parameters) [0x0015e] in …/xamarin-android/external/Java.Interop/external/cecil/Mono.Cecil/BaseAssemblyResolver.cs:161 This error is raised when processing `bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Xamarin.Android.NUnitLite.dll` because [`$(MONO_API_INFO_LIB_DIRS)`][1] contains `-L .../MonoAndroid/v8.0`, but the PR builds are building v7.1, *not* v8.0, and thus `Mono.Android.dll` isn't in a directory which is found. [1]: https://github.com/xamarin/xamarin-android-api-compatibility/blob/49b5789/Makefile#L26-L29 `$(MONO_API_INFO_LIB_DIRS)` is wrong in turn because `make run-api-compatibility-tests` was overriding `$(STABLE_FRAMEWORKS)` to include frameworks which the PR build doesn't build. Update `make run-api-compatibility-tests` so that `$(STABLE_FRAMEWORKS)` isn't overridden. This will allow `xamarin-android-api-compatibility` to probe the frameworks based on what's present, and construct `$(MONO_API_INFO_LIB_DIRS)` accordingly. Additionally, xamarin-android master builds such as [build #538][2] were also failing in an unreported manner: [2]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/538/consoleText Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: '…/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v8.0/OpenTK-1.0.dll, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' at Mono.Cecil.BaseAssemblyResolver.Resolve (Mono.Cecil.AssemblyNameReference name, Mono.Cecil.ReaderParameters parameters) [0x00164] in <336971fa838f4b15a2a3a9274b113045>:0 at CorCompare.AssemblyCollection.LoadAssembly (System.String assembly) [0x0002a] in <d46deda6cbab4407bacfbd3b1ee45bd0>:0 Cannot load assembly file …/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v8.0/OpenTK-1.0.dll The cause for this is that `OpenTK-1.0.dll` is built into the `MonoAndroid/$(AndroidLatestFrameworkVersion)` framework directory, and `Configuration.props` was setting `$(AndroidLatestFrameworkVersion)` to v7.1 (API-25). Update `$(AndroidLatestFrameworkVersion)` to v8.0, and `$(AndroidLatestApiLevel)` to 26.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 12, 2019
Changes: dotnet/java-interop@e7d96f2...f3553f4 Fixes: dotnet/java-interop#534 * dotnet/java-interop@f3553f4: [Java.Interop.Tools.JavaCallableWrappers] XA4213 for mangled methods (dotnet#537) * dotnet/java-interop@0fc4b61: [Java.Interop-Tests] Fix JniTypeTest.Name() missing argument (dotnet#538) * dotnet/java-interop@0065de4: [generator] Mark Kotlin-mangled methods as non-virtual (dotnet#536) * dotnet/java-interop@76d6e6d: Bump to Mono.Linq.Expressions v2.0.0 via NuGet (dotnet#533) * dotnet/java-interop@18c29b7: [Xamarin.Android.Tools.Bytecode] Add @not-null support (dotnet#526) * dotnet/java-interop@1315bfe: Bump to jbevain/mono.linq.expressions@7973f862 (dotnet#529) * dotnet/java-interop@e0d4a7f: [generator] Make _members private (dotnet#522)
jonpryor
added a commit
that referenced
this pull request
Dec 12, 2019
Changes: dotnet/java-interop@e7d96f2...f3553f4 Fixes: dotnet/java-interop#534 * dotnet/java-interop@f3553f4: [Java.Interop.Tools.JavaCallableWrappers] XA4213 for mangled methods (#537) * dotnet/java-interop@0fc4b61: [Java.Interop-Tests] Fix JniTypeTest.Name() missing argument (#538) * dotnet/java-interop@0065de4: [generator] Mark Kotlin-mangled methods as non-virtual (#536) * dotnet/java-interop@76d6e6d: Bump to Mono.Linq.Expressions v2.0.0 via NuGet (#533) * dotnet/java-interop@18c29b7: [Xamarin.Android.Tools.Bytecode] Add @not-null support (#526) * dotnet/java-interop@1315bfe: Bump to jbevain/mono.linq.expressions@7973f862 (#529) * dotnet/java-interop@e0d4a7f: [generator] Make _members private (#522)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary purpose is to bump to cecil/mono-2017-02/6721da21, which
contains a
.pdbfile reader fix.