-
Notifications
You must be signed in to change notification settings - Fork 564
[linker] Add AddKeepAlivesStep #5278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonpryor
merged 11 commits into
dotnet:master
from
brendanzagaeski:addkeepalives-linker
Dec 18, 2020
Merged
[linker] Add AddKeepAlivesStep #5278
jonpryor
merged 11 commits into
dotnet:master
from
brendanzagaeski:addkeepalives-linker
Dec 18, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
3e78301 to
94afe43
Compare
radekdoulik
reviewed
Dec 15, 2020
src/Xamarin.Android.Build.Tasks/Linker/MonoDroid.Tuner/AddKeepAlivesStep.cs
Show resolved
Hide resolved
radekdoulik
reviewed
Dec 15, 2020
src/Xamarin.Android.Build.Tasks/Linker/MonoDroid.Tuner/AddKeepAlivesStep.cs
Outdated
Show resolved
Hide resolved
Other changes: Move a few methods out of `MonoDroidMarkStep` into `Extensions` so `AddKeepAlivesStep` can use them too.
Also ignore string parameters, similar to dotnet/java-interop@1f21f38
Also add it to the cached props
7656be6 to
0a05d12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#719
Modify "old" bindings, so that they hold the object reference
long enough to avoid above issue.
It is implemented as linker step, which looks for offended methods
and injects call to
System.GC.KeepAliveto prevent prematurecollection.
The injection can be disabled with
AndroidAddKeepAlivespropertyset to false.
The property's default value depends on
AndroidIncludeDebugSymbolsproperty and is thus true for release builds and false for debug.
The impact on release build of XA forms template (flyout variety) is
cca 137ms on my machine.
Disabled:
Enabled:
Example updated method body:
Added new
AndroidAddKeepAlivestest toLinkerTests.csto checkwhether registered method was updated.