[Xamarin.Android.Build.Tasks] Revert changes from f06bcbe2 #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit f06bcbe incorrectly changed the way we calculate $(AndroidIncludeDebugSymbols). Tha t value should ONLY be enabled if DebugType is Full or Embedded. I.e if we have a full on debug build. It turns out the source of the problem was the fact that msbuild under OSX was completely ignoring the $(DebugType) property in the csproj. This caused it to always default to 'portable' which is NOT a full debug build.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 12, 2019
Changes: dotnet/java-interop@e7d96f2...f3553f4 Fixes: dotnet/java-interop#534 * dotnet/java-interop@f3553f4: [Java.Interop.Tools.JavaCallableWrappers] XA4213 for mangled methods (dotnet#537) * dotnet/java-interop@0fc4b61: [Java.Interop-Tests] Fix JniTypeTest.Name() missing argument (dotnet#538) * dotnet/java-interop@0065de4: [generator] Mark Kotlin-mangled methods as non-virtual (dotnet#536) * dotnet/java-interop@76d6e6d: Bump to Mono.Linq.Expressions v2.0.0 via NuGet (dotnet#533) * dotnet/java-interop@18c29b7: [Xamarin.Android.Tools.Bytecode] Add @not-null support (dotnet#526) * dotnet/java-interop@1315bfe: Bump to jbevain/mono.linq.expressions@7973f862 (dotnet#529) * dotnet/java-interop@e0d4a7f: [generator] Make _members private (dotnet#522)
jonpryor
added a commit
that referenced
this pull request
Dec 12, 2019
Changes: dotnet/java-interop@e7d96f2...f3553f4 Fixes: dotnet/java-interop#534 * dotnet/java-interop@f3553f4: [Java.Interop.Tools.JavaCallableWrappers] XA4213 for mangled methods (#537) * dotnet/java-interop@0fc4b61: [Java.Interop-Tests] Fix JniTypeTest.Name() missing argument (#538) * dotnet/java-interop@0065de4: [generator] Mark Kotlin-mangled methods as non-virtual (#536) * dotnet/java-interop@76d6e6d: Bump to Mono.Linq.Expressions v2.0.0 via NuGet (#533) * dotnet/java-interop@18c29b7: [Xamarin.Android.Tools.Bytecode] Add @not-null support (#526) * dotnet/java-interop@1315bfe: Bump to jbevain/mono.linq.expressions@7973f862 (#529) * dotnet/java-interop@e0d4a7f: [generator] Make _members private (#522)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit f06bcbe incorrectly changed the way we calculate
$(AndroidIncludeDebugSymbols). Tha t value should ONLY be
enabled if DebugType is Full or Embedded. I.e if we have a full
on debug build.
It turns out the source of the problem was the fact that msbuild
under OSX was completely ignoring the $(DebugType) property in
the csproj. This caused it to always default to 'portable' which
is NOT a full debug build.