Bump to Android SDK Build-tools 29.0.2 #4749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android-tools#85 Context: dotnet#4567 Partially reverts commit 5ad666d. Commit 5ad666d bumped the Android SDK Build-tools version that `xaprepare` installs to be 30.0.0-rc4, which is problematic becuase it contains an `apksigner.jar` which requires JDK11, support for which has not yet been merged (see PR dotnet#4567). In retrospect, bumping the `$(XABuildToolsVersion)` value was a Bad Idea™. It was the `DexUtils.cs` change that we wanted. Revert the `$(XABuildToolsVersion)` bump, and thus once again provision Android SDK Build-tools 29.0.2.
jpobst
approved these changes
Jun 2, 2020
dellis1972
approved these changes
Jun 2, 2020
jonpryor
added a commit
that referenced
this pull request
Jun 2, 2020
Context: dotnet/android-tools#85 Context: #4567 Partially reverts commit 5ad666d. Commit 5ad666d bumped the Android SDK Build-tools version that `xaprepare` installs to be 30.0.0-rc4, which is problematic becuase it contains an `apksigner.jar` which requires JDK11, support for which has not yet been merged (see PR #4567). In retrospect, bumping the `$(XABuildToolsVersion)` value was a Bad Idea™. It was the `DexUtils.cs` change that we wanted. Revert the `$(XABuildToolsVersion)` bump, and thus once again provision Android SDK Build-tools 29.0.2.
jonathanpeppers
added a commit
that referenced
this pull request
Jun 2, 2020
This reverts commit 850d812.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android-tools#85
Context: #4567
Partially reverts commit 5ad666d.
Commit 5ad666d bumped the Android SDK Build-tools version that
xaprepareinstalls to be 30.0.0-rc4, which is problematic becuase itcontains an
apksigner.jarwhich requires JDK11, support for whichhas not yet been merged (see PR #4567).
In retrospect, bumping the
$(XABuildToolsVersion)value was aBad Idea™. It was the
DexUtils.cschange that we wanted.Revert the
$(XABuildToolsVersion)bump, and thus once again provisionAndroid SDK Build-tools 29.0.2.