Bump to xamarin/java.interop@cedf4d0 #4347
Conversation
pjcollins
force-pushed
the
test-ji-more-sdk
branch
5 times, most recently
from
760ec20 to
b9233ec
Compare
pjcollins
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
pjcollins
force-pushed
the
test-ji-more-sdk
branch
from
528aa3d to
bcd2cad
Compare
pjcollins
changed the title
| <_ILRepackArgs>/out:"$(MSBuildThisFileDirectory)$(IntermediateOutputPath)$(AssemblyName).dll" /internalize</_ILRepackArgs> | ||
| <_ILRepackArgs>$(_ILRepackArgs) "$(MSBuildThisFileDirectory)$(IntermediateOutputPath)$(AssemblyName).dll"</_ILRepackArgs> | ||
| <_ILRepackArgs>$(_ILRepackArgs) @(_InputAssembliesThatExist->'"%(Identity)"', ' ')</_ILRepackArgs> | ||
| <_ILRepackArgs>$(_ILRepackArgs) /lib:"$(XAInstallPrefix)xbuild-frameworks\MonoAndroid\v1.0\facades"</_ILRepackArgs> <!-- Path to netstandard.dll --> |
There was a problem hiding this comment.
I'm wondering if this is right... netstandard.dll in this case is coming from our build tree, and meant for Xamarin.Android projects. Xamarin.Android.Build.Tasks is a desktop assembly, should it be using Mono's system install of netstandard.dll instead?
There was a problem hiding this comment.
We were previously repacking against the netstandard.dll that was copied into this directory by some Java.Interop project. Maybe we can do something similar to what macios is doing here... https://github.com/xamarin/xamarin-macios/blob/0557f16e6a936f9d3c94fe020536141296b42640/msbuild/ILMerge.targets#L13
There was a problem hiding this comment.
I just rebuilt on macOS with the latest changes, and we should now using a path from the .NET Core installation:
/lib:"/usr/local/share/dotnet/sdk/NuGetFallbackFolder/netstandard.library/2.0.3/build/netstandard2.0/ref/"
There was a problem hiding this comment.
Looks like Windows wasn't happy with this approach
Edit trimming the trailing path separator seems to make the tool invocation on Windows happy.
|
Squash-and-merge commit message: Changes: https://github.com/xamarin/java.interop/compare/bd7c60a6a5ea8abaf6f241da17c42d2d93226bf2...cedf4d04c7bf1f327d615a0316cbeabe59be5454
* xamarin/Java.Interop@cedf4d0: [build] Convert more projects to Short-Form projects (#547)
Update `src/Mono.Android` to not check target framework of referenced
console apps. These project references only exist to ensure a
particular build order, so we can skip target framework version
compatibility checks. |
|
Re-running, we hit a bot which doesn't have powershell installed... |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
These project references only exist to ensure a particular build order, so we can skip target framework version compatibility checks.
This reverts commit 98fb8c6.
This is no longer in the XA build tasks output dir
pjcollins
force-pushed
the
test-ji-more-sdk
branch
from
2145a01 to
7008d08
Compare
Changes: dotnet/java-interop@a84d19e...2cab35c * dotnet/java-interop@2cab35cc: [build] Convert more projects to Short-Form projects (#547) Update `src/Mono.Android` to not check target framework of referenced console apps. These project references only exist to ensure a particular build order, so we can skip target framework version compatibility checks.
These project references only exist to ensure a particular build order,
so we can skip target framework version compatibility checks.