Allocate directory array with correct type #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#3759 Context: dotnet@6d85759#diff-e99739c16155208685952aa52870d4cdL33-L39 When switching from C-style `xcalloc` to C++-style `new` I failed to use the proper type to allocate array which holds directories where Android placed the APK files of the application. This mistake manifested itself only when using AppBundles, which is where we allocate more than one entry of the array. The resulting error was the following runtime exception: 11-04 12:27:55.722 3339 3339 E mono : Unhandled Exception: 11-04 12:27:55.722 3339 3339 E mono : System.DllNotFoundException: __Internal assembly:<unknown assembly> type:<unknown type> member:(null) 11-04 12:27:55.722 3339 3339 E mono : at (wrapper managed-to-native) Android.Runtime.JNIEnv.monodroid_timing_start(string) Which occurred because Xamarin.Android runtime failed to load `libmonodroid.so` from one of the directories that should have been stored in the array mentioned above - usually found in the *last* entry of the array. When iterating over the array, the XA runtime would end up with a null pointer after the end of the array instead of a pointer to the last entry. This commit uses the proper type when allocating the array.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
added
the
full-mono-integration-build
Contributor
Author
|
build |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Considering all the grief we went through with PR #3796, is it possible to create a test case which triggers the scenario? Do we know why this only "randomly" failed instead of consistently failed? |
Contributor
Author
I was thinking about it and I can't figure out why it failed intermittently. The AppBundle is, however, THE test case that triggered it so I think we are at least partially covered |
jonpryor
pushed a commit
that referenced
this pull request
Nov 12, 2019
Context: 6d85759 Context: #3796 Context: 6d85759#diff-e99739c16155208685952aa52870d4cdL33-L39 When switching from C-style `xcalloc()` to C++-style `new` I failed to use the proper type to allocate the array which holds directories where Android placed the `.apk` files of the application. This mistake manifested itself only when using AppBundles, which is where we allocate more than one entry of the array. The resulting error was the following runtime exception: Unhandled Exception: System.DllNotFoundException: __Internal assembly:<unknown assembly> type:<unknown type> member:(null) at (wrapper managed-to-native) Android.Runtime.JNIEnv.monodroid_timing_start(string) which occurred because the Xamarin.Android runtime failed to load `libmonodroid.so` from one of the directories that should have been stored in the array mentioned above - usually found in the *last* entry of the array. When iterating over the array, the XA runtime would end up with a null pointer after the end of the array instead of a pointer to the last entry. This commit uses the proper type when allocating the array.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #3759
Context: 6d85759#diff-e99739c16155208685952aa52870d4cdL33-L39
When switching from C-style
xcallocto C++-stylenewI failed to use theproper type to allocate array which holds directories where Android placed the
APK files of the application. This mistake manifested itself only when using
AppBundles, which is where we allocate more than one entry of the array. The
resulting error was the following runtime exception:
Which occurred because Xamarin.Android runtime failed to load
libmonodroid.sofrom one of the directories that should have been stored in the array mentioned
above - usually found in the last entry of the array. When iterating over the
array, the XA runtime would end up with a null pointer after the end of the
array instead of a pointer to the last entry.
This commit uses the proper type when allocating the array.