[Xamarin.Android.Build.Tests] Port Tests from commercial repo #2980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
changed the title
As part of a move to unify our unit tests into the main repo this PR brings in all the InstantRun tests. They are protected bbehind a `CommercialBuildAvailable` check which will only be `true` if the commercial parts are available. The commercial tests are also flagged with a nunit category attribute of `Commercial` just in case we decide to filter in the future. This PR also makes some changes to the folder structure. ALL `Task` based tests (i.e ones that test just a Task using the MockBbuildEngine) have been moved into the `Tasks` folder. We already have a few tests in that folder, this make sure they are all in one place. the `*.OSS.cs` partial class files have been renamed to `*.TestCaseSource.cs`. They also handle the tests for BOTH open source and commercial builds. As a result they will not longer be needed in the commercial repo. They were also moved into the shared project. This change will probably cause commercial build failures until PR dotnet#966 is merged on the commercial side.
| Assert.Ignore ("Not required on Open Source Builds"); | ||
|
|
||
| if (!HasDevices) { | ||
| Assert.Ignore ("Test Skipped no devices or emulators found."); |
Member
There was a problem hiding this comment.
monodroid has some EmulatorHelper.csproj that starts the emulator. Do we need something like that in this PR?
It might be we can use the newer MSBuild tasks in this repo to do that.
jonpryor
pushed a commit
that referenced
this pull request
Apr 16, 2019
Commit 66d0165 [broke the macOS build][0]: …/xamarin-android/tests/MSBuildDeviceIntegration/MSBuildDeviceIntegration.targets(18,5): error MSB3030: Could not copy the file "../../bin/TestRelease/Xamarin.Android.Cecil.Mdb.dll" because it was not found. This was probably "overlooked" because the builds for PR #2980 didn't include bf58a88/PR #2855. Update the paths used for `Xamarin.Android.Cecil*.dll` so that `MSBuildDeviceIntegration.targets` can run without error. [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/463/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a move to unify our unit tests into the
main repo this PR brings in all the InstantRun tests.
They are protected bbehind a
CommercialBuildAvailablecheck which will only be
trueif the commercial partsare available. The commercial tests are also flagged with
a nunit category attribute of
Commercialjust in case wedecide to filter in the future.
This PR also makes some changes to the folder structure.
ALL
Taskbased tests (i.e ones that test just a Task usingthe MockBbuildEngine) have been moved into the
Tasksfolder.We already have a few tests in that folder, this make sure
they are all in one place.
the
*.OSS.cspartial class files have been renamed to*.TestCaseSource.cs. They also handle the tests for BOTHopen source and commercial builds. As a result they will
not longer be needed in the commercial repo. They were also
moved into the shared project. This change will probably cause
commercial build failures until PR #966 is merged on the
commercial side.