[java-runtime] Remove final from MonoPackageManager_Resources #2878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 75023bd we noticed an issue the value of `MonoPackageManager_Resouces.ApiPackageName` was `""` even after it was replaced at built time with a new `.class` file which contained an actual value. The fix in that PR was to make the temp file in java-runtime have a value of `null` rather than `""`. This made thing work but we didn't know WHY. After some more investigation it turns out that the value was being inlined by the java compiler. public static java.lang.String getApiPackageName(); descriptor: ()Ljava/lang/String; Code: 0: ldc #48 // String 2: areturn The code above is pointing to a string in the Constants table. What we were expecting was that the statick method would be called in the file generated by the build system. Making the temp file have a `null` rather than `""` resulted in the following code public static java.lang.String getApiPackageName(); descriptor: ()Ljava/lang/String; Code: 0: getstatic #47 // Field mono/MonoPackageManager_Resources.ApiPackageName:Ljava/lang/String; 3: areturn This is why changing to `null` worked. It prevented the compiler from inlining the value. This commit removes the `final` keyword from the `MonoPackageManager_Resources` class fields to make sure that they never get inlined.
Member
jonathanpeppers
approved these changes
Mar 26, 2019
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I think we can ignore the test failure:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(114,5): Unable to load the service index for source https://msazure.pkgs.visualstudio.com/_packaging/Dev/nuget/v3/index.json.
Response status code does not indicate success: 401 (Unauthorized). [E:\A\_work\910\s\bin\TestRelease\temp\BuildBasicApplicationFSharp\UnnamedProject.fsproj]
Member
|
It may be worth linking to: https://stackoverflow.com/questions/3524150/is-it-possible-to-disable-javacs-inlining-of-static-final-variables Apparently there are not any good ways to prevent the inlining here... There are some other options on here, though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 75023bd we noticed an issue the
value of
MonoPackageManager_Resouces.ApiPackageNamewas""even after it was replaced at built time with a new.classfile which contained an actual value.The fix in that PR was to make the temp file in java-runtime
have a value of
nullrather than"". This made thing workbut we didn't know WHY.
After some more investigation it turns out that the value
was being inlined by the java compiler.
The code above is pointing to a string in the Constants table.
What we were expecting was that the statick method would be
called in the file generated by the build system. Making
the temp file have a
nullrather than""resulted in thefollowing code
This is why changing to
nullworked. It prevented the compilerfrom inlining the value.
This commit removes the
finalkeyword from theMonoPackageManager_Resourcesclass fields to make sure that they never get inlined.