[Tests] Make network tests a bit more resilient #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We often see networ test "failures" caused by unreachability of one of the servers those tests use. This creates false negatives since this is not really the test failing but rather the environment not being correct and preventing the test from performing its actual task. This commit catches the `WebException` thrown in connection failed cases and merely ignores the test instead of failing it. Full exception message and stack trace is printed as part of the ignore message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often see networ test "failures" caused by unreachability of one of the
servers those tests use. This creates false negatives since this is not really
the test failing but rather the environment not being correct and preventing the
test from performing its actual task.
This commit catches the
WebExceptionthrown in connection failed cases andmerely ignores the test instead of failing it. Full exception message and stack
trace is printed as part of the ignore message.