[monodroid] Allow the SGEN Bridge version to be specified #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Thanks. |
Contributor
Author
|
I believe |
[Mono has support for improved SGEN GC Bridge behavior][0] which bumps the value of `SGEN_BRIDGE_VERSION` from `4` to `5`, and will be present within Mono 4.8. Xamarin.Android, meanwhile, is currently targeting Mono 4.6, which won't be getting support for this new SGEN bridge version. What is desired is a way to use xamarin-android with Mono 4.7/4.8 to test out the new GC bridge behavior, without breaking existing Mono 4.6 support. The solution is a new MSBuild property, `$(MonoSgenBridgeVersion)`, which allows overriding the `SGEN_BRIDGE_VERSION` value used when building the `libmono-android` native library. By default this MSBuild prpoperty is `4`, for compatibility with Mono 4.6. [0]: https://github.com/mono/mono/pull/3422/files
jonpryor
force-pushed
the
jonp-sgen-bridge-version
branch
from
2d25f0e to
ee5c88f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono has support for improved SGEN GC Bridge behavior which bumps
the value of
SGEN_BRIDGE_VERSIONfrom4to5, and will bepresent within Mono 4.8.
Xamarin.Android, meanwhile, is currently targeting Mono 4.6, which
won't be getting support for this new SGEN bridge version.
What is desired is a way to use xamarin-android with Mono 4.7/4.8 to
test out the new GC bridge behavior, without breaking existing
Mono 4.6 support.
The solution is a new MSBuild property,
$(MonoSgenBridgeVersion),which allows overriding the
SGEN_BRIDGE_VERSIONvalue used whenbuilding the
libmono-androidnative library.By default this MSBuild prpoperty is
4, for compatibility withMono 4.6.