[android-toolchain] Fix the _CreateMxeW32Toolchain Condition.
#122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_CreateMxeW32Toolchaintarget condition checked for:mxe-Win64:, not:mxe-Win32:, which caused it to needlessly runwhenever
:mxe-Win64:was set (spending extra time), while notrunning when it was requested, i.e. when
:mxe-Win32:was set.Additionally, I previously had an MXE SNAFU wherein
android-toolchain.targetswas updated to buildzlib, but my localbuild output didn't contain
zliboutputs. This resulted in obscurebuild errors and needless tearing out of limited hair, which could
have been avoided if the
zliboutputs had been listed as outputsthat could be checked for.
Thus, rework the existing
_CreateMxeW32Toolchainand_CreateMxeW64Toolchaindichotomy, and instead introduce a new@(_AndroidMxeToolchain)item group with conditional values based on$(AndroidSupportedHostJitAbisForConditionalChecks). This allows fora more "extensible" output file format that doesn't needlessly copy
obscure identifiers like
i686-w64-mingw32.staticfor output files._CreateMxeW32Toolchainand_CreateMxeW64Toolchainare dead; longlive
_CreateMxeToolchains!