[Xamarin.Android.Build.Tasks] ProGuard/MultiDex fix parentheses in path #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1135
Context: #1068
When making changes in #1068, I added a unit test that builds an
application with both spaces and parentheses in its path. However, this
was not enough to test everything; the test also needed an
AndroidJavaLibrarybuild item with spaces and parentheses in its name!Changes:
Hello (World).jarfile, that has a single class in itAndroidJavaLibrary, inthe
BuildApplicationWithSpacesInPathtestProguard.csandCreateMultiDexMainDexClassList.csfromwhat I did in [Xamarin.Android.Build.Tasks] fix for proguard enclosing char on windows #1068 -- Dean tried to warn me
(!META-INF/MANIFEST.MF)filter expression outside thesingle quotes
-injarsexpression to work on both macOS and Windows,I had to enclose the entire expression in double-quotes
PR #1068 was a good attempt at trying to cleanup the code, but I could
not get the manifest filter to work along with a path including a
parentheses.