[build] fix Novell/*.MonoDroid.*.targets copy during build #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a little while, our build has been copying three files to the root of our build tree: - Novell/MonoDroid.FSharp.targets - Novell/Novell.MonoDroid.Common.targets - Novell/Novell.MonoDroid.CSharp.targets These files are copied to build output in the Xamarin.Android.Build.Tasks project, but they should go in `bin/$(Configuration)` not the root of the build tree. While looking at binary log output, I noticed the Xamarin.Android.Build.Tests project was doing the copy due to having a `<ProjectReference />` to Xamarin.Android.Build.Tasks. Adding `<Private>False</Private>` to the `<ProjectReference />` fixes these files from being copied, and doesn't appear to have any other ill effects.
jonathanpeppers
force-pushed
the
weird-targets-output
branch
from
4a4579e to
39e85c1
Compare
Member
Author
|
build |
Member
Author
|
Need to look and see if there is another way to fix this--it looks like it breaks a set of tests. I believe this started happening in this commit, when a |
Member
Author
|
I'll revisit this when I am back with a different PR, the changes here didn't do what we needed. |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 3, 2020
Changes: https://github.com/xamarin/monodroid/compare/34f5275d1db891e25af17d743b425cc318e6e7df...846697287fb32c38b54ddd2fe21964b9159b2750 * xamarin/monodroid@846697287: Bump to xamarin/androidtools/master@8a2cadb5 (dotnet#1079) * xamarin/monodroid@9d045f82f: Bump to xamarin/android-sdk-installer/master@33a209cc (dotnet#1078)
jonpryor
added a commit
that referenced
this pull request
Apr 3, 2020
Changes: https://github.com/xamarin/monodroid/compare/34f5275d1db891e25af17d743b425cc318e6e7df...846697287fb32c38b54ddd2fe21964b9159b2750 * xamarin/monodroid@846697287: Bump to xamarin/androidtools/master@8a2cadb5 (#1079) * xamarin/monodroid@9d045f82f: Bump to xamarin/android-sdk-installer/master@33a209cc (#1078)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a little while, our build has been copying three files to the root
of our build tree:
These files are copied to build output in the
Xamarin.Android.Build.Tasks project, but they should go in
bin/$(Configuration)not the root of the build tree.While looking at binary log output, I noticed the
Xamarin.Android.Build.Tests project was doing the copy due to having a
<ProjectReference />to Xamarin.Android.Build.Tasks.Adding
<Private>False</Private>to the<ProjectReference />fixesthese files from being copied, and doesn't appear to have any other ill
effects.