[Xamarin.ProjectTools] Only add the process.log if it exists. #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an additional check to only process the process.log if the file exists. We might be in a situation where nothing is written to StdOut or StdErr as a result we might not get a log file. So lets not crash the test if it does not exist.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Feb 1, 2020
Changes: https://github.com/xamarin/monodroid/compare/017b3618bd33689f766e82b5fd640360e4c19919...01a4e0a0c436bf1b0b62acf870cc06e67e62034c Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1033784 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1035905 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/946984 Context: icsharpcode/SharpZipLib#356 * xamarin/monodroid@01a4e0a0c: Bump to xamarin/androidtools/master@2ffbfcb7 (dotnet#1074) * xamarin/monodroid@987ce4d1b: Remove external/debugger-libs (dotnet#1072) * xamarin/monodroid@7ded15051: Bump to mono/debugger-libs@5e5b5efb (dotnet#1071) * xamarin/monodroid@072746460: Bump to xamarin/android-sdk-installer/master@c694d0da (dotnet#1070)
jonpryor
added a commit
that referenced
this pull request
Feb 1, 2020
Changes: https://github.com/xamarin/monodroid/compare/017b3618bd33689f766e82b5fd640360e4c19919...01a4e0a0c436bf1b0b62acf870cc06e67e62034c Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1033784 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1035905 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/946984 Context: icsharpcode/SharpZipLib#356 * xamarin/monodroid@01a4e0a0c: Bump to xamarin/androidtools/master@2ffbfcb7 (#1074) * xamarin/monodroid@987ce4d1b: Remove external/debugger-libs (#1072) * xamarin/monodroid@7ded15051: Bump to mono/debugger-libs@5e5b5efb (#1071) * xamarin/monodroid@072746460: Bump to xamarin/android-sdk-installer/master@c694d0da (#1070)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an additional check to only process the
process.log if the file exists. We might be in a situation
where nothing is written to StdOut or StdErr as a result we
might not get a log file. So lets not crash the test if it
does not exist.