[xabt] default $(AndroidEnableMarshalMethods)=false for CoreCLR
#10492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #10491 Context: #10245 In 9861b57, We enabled `$(PublishReadyToRun)` by default in `Release` mode, and so we also need to disable `$(AndroidEnableMarshalMethods)` as it does not work in combination with R2R yet. This is really a build ordering issue, that we'll need to significantly rework in the future. We didn't notice this issue, because we were explicitly passing `-p:AndroidEnableMarshalMethods=false` to the CoreCLR on-device tests. I also cleaned up a few MSBuild tests to use the `EnableMarshalMethods` property.
simonrozsival
approved these changes
Sep 16, 2025
grendello
approved these changes
Sep 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10491
Context: #10245
In 9861b57, We enabled
$(PublishReadyToRun)by default inReleasemode, and so we also need to disable$(AndroidEnableMarshalMethods)as it does not work in combination with R2R yet. This is really a build ordering issue, that we'll need to significantly rework in the future.We didn't notice this issue, because we were explicitly passing
-p:AndroidEnableMarshalMethods=falseto the CoreCLR on-device tests.I also cleaned up a few MSBuild tests to use the
EnableMarshalMethodsproperty.