Fix an ABI break #10487
Merged
Fix an ABI break #10487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 869b0e0 869b0e0 had an ABI break which exposed an internal JNI reference manager (`AndroidObjectReferenceManager`) class as public in order to use it from the NativeAOT runtime host. Initially I thought the fix would be harder, but... it's not :) - all we need to do is to make the class `internal`, which is what this commit does. Additionally, sort-of revert one more change in 869b0e0, which downgraded a GC diagnostic message from the `Info` log level to `Debug`. The message is actually useful and warns about a potential issue with the GC machinery, so let's emit it is as a warning.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an ABI break by reverting visibility changes to internal classes and adjusting log levels. The changes address issues introduced in commit 869b0e0 that inadvertently exposed internal implementation details.
- Change
AndroidObjectReferenceManagerclass from public back to internal access modifier - Restore GC diagnostic message log level from Debug back to Warn
Contributor
Author
|
The `` test fails with The failures don't appear to be related to this PR |
jonathanpeppers
approved these changes
Sep 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 869b0e0
869b0e0 had an ABI break which exposed an internal JNI reference
manager (
AndroidObjectReferenceManager) class as public in orderto use it from the NativeAOT runtime host.
Initially I thought the fix would be harder, but... it's not :) -
all we need to do is to make the class
internal, which is what thiscommit does.
Additionally, sort-of revert one more change in 869b0e0, which
downgraded a GC diagnostic message from the
Infolog level toDebug. The message is actually useful and warns about a potentialissue with the GC machinery, so let's emit it is as a warning.