Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 28, 2025

This PR removes all obsolete monoandroid10 references from MSBuild files throughout the repository. These references are leftover from Xamarin.Android and are no longer needed in .NET for Android.

The changes inline conditions containing monoandroid10 as if they evaluate to false, and remove statements that would never be evaluated:

Changes Made

Java.Interop.targets

  • Removed the entire BuildVersionInfo_g_cs target that only executed for monoandroid10

Mono.Android.Runtime.targets

  • Simplified package version conditions to always use AndroidPackVersion instead of conditionally choosing between ProductVersion and AndroidPackVersion

Mono.Android.Runtime.csproj

  • Removed obsolete build dependency condition for classic Xamarin.Android (API > 33)
  • Simplified remaining conditions to only check AndroidApiLevel without the TargetFramework checks

JavaCallableWrappers.targets

  • Simplified library path conditions to always use the corlib directory path instead of conditionally choosing between v1.0 facades and corlib

Xamarin.Android.NamingCustomAttributes.projitems

  • Updated condition from monoandroid10 OR netstandard2.0 to just netstandard2.0

All changes maintain proper XML structure and are minimal, surgical modifications that preserve existing functionality while removing the obsolete framework references.

Fixes #10451.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] [build] cleanup monoandroid10 references in MSBuild files [build] cleanup monoandroid10 references in MSBuild files Aug 28, 2025
Copilot AI requested a review from jonathanpeppers August 28, 2025 16:25
@jonathanpeppers
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonathanpeppers jonathanpeppers marked this pull request as ready for review August 28, 2025 18:00
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) August 28, 2025 18:01
@jonathanpeppers jonathanpeppers merged commit 738e4e1 into main Aug 28, 2025
58 of 60 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-10451 branch August 28, 2025 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[build] cleanup monoandroid10 references in MSBuild files

2 participants