[Mono.Android] undo trimmer attribute to restore apk size #10448
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/maui#31316 (comment) In comparing apk sizes .NET 9 vs .NET 10, we found regressions in IL size, such as: + 76,464 lib/x86_64/libaot-Mono.Android.dll.so Comparing, just the MSIL (not AOT output) some examples are `Java.IO.File` constructors: .NET 9: File() File(nint, JniHandleOwnership) File(string) .NET 10: File() File(nint, JniHandleOwnership) File(File?, string) File(string?, string) File(string) File(URI) When passing `-p:LinkerDumpDependencies=true`, we can get some output from `ILLink`: <edge mark="1" b="MethodSpec:T Java.Lang.Object::GetObject<Java.IO.File>(System.IntPtr,Android.Runtime.JniHandleOwnership)" e="TypeDef:Java.IO.File" /> <edge mark="1" b="Method:Java.IO.File Android.Content.ContextInvoker::get_CacheDir()" e="Method:System.Void Java.IO.File::.ctor(System.IntPtr,Android.Runtime.JniHandleOwnership)" /> <edge mark="1" b="Method:Java.IO.File Android.Content.ContextInvoker::get_CacheDir()" e="Method:System.Void Java.IO.File::.cctor()" /> <edge mark="1" b="Method:Java.IO.File Android.Content.ContextInvoker::get_CacheDir()" e="Method:System.Void Java.IO.File::.ctor(Java.IO.File,System.String)" /> <edge mark="1" b="Method:Java.IO.File Android.Content.ContextInvoker::get_CacheDir()" e="Method:System.Void Java.IO.File::.ctor(System.String,System.String)" /> <edge mark="1" b="Method:Java.IO.File Android.Content.ContextInvoker::get_CacheDir()" e="Method:System.Void Java.IO.File::.ctor(System.String)" /> <edge mark="1" b="Method:Java.IO.File Android.Content.ContextInvoker::get_CacheDir()" e="Method:System.Void Java.IO.File::.ctor(Java.Net.URI)" /> Which leads me think this change is the cause: * f800c1a#diff-4d71f7134c2b6e3b0d272a17fc6c9261108c518ad039df1566b07205f6be06e9R146 Let's try just undoing the change and see if there is any impact on NativeAOT. TODO: apk size difference
Member
Author
|
This fixes those additional 
Gets back some of the file size: |
Member
Author
|
Ok, here is the exact comparison of just this change: I think there are more regressions in IL size, I'll investigate next. |
simonrozsival
approved these changes
Aug 27, 2025
grendello
approved these changes
Aug 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/maui#31316 (comment)
In comparing apk sizes .NET 9 vs .NET 10, we found regressions in IL size, such as:
Comparing, just the MSIL (not AOT output) some examples are
Java.IO.Fileconstructors:When passing
-p:LinkerDumpDependencies=true, we can get some output fromILLink:Which leads me think this change is the cause:
Let's try just undoing the change and see if there is any impact on NativeAOT.
TODO: apk size difference