[NativeAOT] remove @(KnownILCompilerPack) hack
#10413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In d84352c, I was trying to workaround the error: D:\.nuget\packages\microsoft.dotnet.ilcompiler\10.0.0-rc.1.25412.102\build\Microsoft.NETCore.Native.Publish.targets(70,5): The PrivateSdkAssemblies ItemGroup is required for _ComputeAssembliesToCompileToNative But at that time, I was experimenting with the `$(PublishAotUsingRuntimePack)` property. This problem only occurs if `$(PublishAotUsingRuntimePack)` is *not* set, which we do by default in dotnet/android/main. It appears we can just remove this workaround.
jkoritzinsky
approved these changes
Aug 13, 2025
filipnavara
approved these changes
Aug 14, 2025
grendello
approved these changes
Aug 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d84352c, I was trying to workaround the error:
But at that time, I was experimenting with the
$(PublishAotUsingRuntimePack)property. This problem only occurs if$(PublishAotUsingRuntimePack)is not set, which we do by default in dotnet/android/main.It appears we can just remove this workaround.