Skip to content

Conversation

@grendello
Copy link
Contributor

@grendello grendello commented Aug 8, 2025

Fixes: #10382
Context: f37158e

f37158e switched to string blobs when storing environment variables
in libxamarin-app.so.

In case of an odd count of envvars, we'd fail to set them because
of a check that should have been removed in f37158e

Remove verification that there's an even number of elements in the
environment variable array, it is no longer necessary.

@grendello grendello marked this pull request as draft August 8, 2025 15:23
In case of an odd count of envvars, we'd fail to set them because
of an old check that should have been removed in f37158e

Remove verification that there's an even number of elements in the
environment variable array, it is no longer necessary.
@grendello grendello force-pushed the dev/grendel/native-envvar-fix branch from c7d8f5b to cde47e3 Compare August 8, 2025 15:33
@grendello grendello marked this pull request as ready for review August 8, 2025 15:34
@grendello
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonathanpeppers jonathanpeppers enabled auto-merge (squash) August 8, 2025 20:40
@jonathanpeppers jonathanpeppers merged commit 12f8376 into main Aug 8, 2025
60 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/grendel/native-envvar-fix branch August 8, 2025 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[clr,native] Environment variables array is subtly broken

3 participants