Skip to content

Make 7z able to handle symlinks in the NDK zip again #10392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathanpeppers merged 1 commit into from
Aug 8, 2025
Merged

Make 7z able to handle symlinks in the NDK zip again #10392

jonathanpeppers merged 1 commit into from
Aug 8, 2025

Conversation

@grendello
Copy link
Contributor

@grendello grendello commented Aug 8, 2025

Fixes: #10387
Context: https://sourceforge.net/p/sevenzip/discussion/45797/thread/da14cd780b/
Context: https://github.com/ip7z/7zip/releases/tag/25.01

With the release of 7z 25.01, the previously used -snld switch stopped working when
unpacking Android NDK archives:

stderr | ERROR: Dangerous link via another link was ignored : android-ndk-r28c/toolchains/llvm/prebuilt/linux-x86_64/lib/libc++.so.1 : x86_64-unknown-linux-gnu/libc++.so.1
stderr | ERROR: Dangerous link via another link was ignored : android-ndk-r28c/toolchains/llvm/prebuilt/linux-x86_64/lib/libc++abi.so.1 : x86_64-unknown-linux-gnu/libc++abi.so.1
stderr | ERROR: Dangerous link via another link was ignored : android-ndk-r28c/toolchains/llvm/prebuilt/linux-x86_64/bin/ld : ld.lld

I've seen it only on my Linux PC which uses Debian/unstable, but the problem will show itself
on macOS and Windows as well with the new 7z version.

Instead of switching to System.IO.Compression, as suggested in the issue, this PR adds
support for the new -snld20 switch added in 7z 25.01 and which makes 7z able to handle
NDK archives again.

@jonathanpeppers jonathanpeppers merged commit 5cabb36 into main Aug 8, 2025
57 of 59 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/grendel/7z-symlinks-ndk branch August 8, 2025 15:18
@grendello grendello restored the dev/grendel/7z-symlinks-ndk branch August 8, 2025 15:24
@grendello grendello deleted the dev/grendel/7z-symlinks-ndk branch August 8, 2025 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7z cannot handle new NDK zips

3 participants

@grendello @jonathanpeppers