[xabt] fix default trimmer switches for Metrics
#10388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The one |
grendello
approved these changes
Aug 8, 2025
lateralusX
reviewed
Aug 8, 2025
| <DebuggerSupport Condition=" '$(DebuggerSupport)' == '' ">false</DebuggerSupport> | ||
| <HttpActivityPropagationSupport Condition=" '$(HttpActivityPropagationSupport)' == '' ">false</HttpActivityPropagationSupport> | ||
| <!-- Only set if *not* using $(EnableDiagnostics) --> | ||
| <MetricsSupport Condition=" '$(MetricsSupport)' == '' and '$(AndroidEnableProfiler)' != 'true' ">false</MetricsSupport> |
Member
There was a problem hiding this comment.
There is a use case just profiling or tracing the native runtime events that doesn't need the large set of diagnostic libraries on Release. With this change users needs to opt out of metric + event source if they enable AndroidEnableProfiler on Release builds. I guess that is fine, just want to point out the scenario and that we might need to document how to run under that configuration when we enable more libraries in Release builds by default.
Member
Author
There was a problem hiding this comment.
Let me at least document some of this in here for now:
We sync this markdown file with mslearn.
Context: https://github.com/jonathanpeppers/MauiAspireWithTelemetry/tree/peppers Context: dotnet/maui#31058 We are in the process of adding `Metrics` to .NET MAUI to enable `dotnet-counters` such as: > dotnet-counters monitor --dsrouter android --counters Microsoft.Maui Press p to pause, r to resume, q to quit. Status: Running Name Current Value [Microsoft.Maui] maui.layout.arrange_count ({times}) 6 maui.layout.arrange_duration (ns) Percentile 50 518,656 95 2,367,488 99 2,367,488 maui.layout.measure_count ({times}) 11 maui.layout.measure_duration (ns) Percentile 50 389,632 95 28,475,392 99 28,475,392 For this to work, you'd unfortunately need to build the app with: dotnet build -c Release -p:EnableDiagnostics=true -p:MetricsSupport=true -p:EventSourceSupport=true That's way too many properties to mess with! So, we should make the defaults: * For `Release` mode, `$(Optimize)` is `true`. * Only if `$(AndroidEnableProfiler)` and `$(EnableDiagnostics)` are not `true`, then: * `$(MetricsSupport)` is `false`. * `$(EventSourceSupport)` is `false`. I also refactored other properties that default to `false` in Release mode by checking the `$(Optimize)` property.
jonathanpeppers
force-pushed
the
dev/peppers/trimmer-Metrics
branch
from
e529a1f to
9e6a3e2
Compare
Member
Author
|
/cc @rolfbjarne I guess we will want some of the same defaults on iOS: |
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
Aug 11, 2025
…icsSupport'. Context: dotnet/maui#31058 Context: dotnet/android#10388 We are in the process of adding `Metrics` to .NET MAUI to enable `dotnet-counters` such as: > dotnet-counters monitor --dsrouter ios --counters Microsoft.Maui Press p to pause, r to resume, q to quit. Status: Running Name Current Value [Microsoft.Maui] maui.layout.arrange_count ({times}) 6 maui.layout.arrange_duration (ns) Percentile 50 518,656 95 2,367,488 99 2,367,488 maui.layout.measure_count ({times}) 11 maui.layout.measure_duration (ns) Percentile 50 389,632 95 28,475,392 99 28,475,392 For this to work, you'd unfortunately need to build the app with: dotnet build -c Release -p:EnableDiagnostics=true -p:MetricsSupport=true -p:EventSourceSupport=true That's way too many properties to mess with! So, we should make the defaults: * For `Release` mode, `$(Optimize)` is `true`. * Only if `$(EnableDiagnostics)` is not `true`, then: * `$(MetricsSupport)` is `false`. * `$(EventSourceSupport)` is `false`.
Member
|
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
Aug 12, 2025
…icsSupport'. (#23543) Context: dotnet/maui#31058 Context: dotnet/android#10388 We are in the process of adding `Metrics` to .NET MAUI to enable `dotnet-counters` such as: > dotnet-counters monitor --dsrouter ios --counters Microsoft.Maui Press p to pause, r to resume, q to quit. Status: Running Name Current Value [Microsoft.Maui] maui.layout.arrange_count ({times}) 6 maui.layout.arrange_duration (ns) Percentile 50 518,656 95 2,367,488 99 2,367,488 maui.layout.measure_count ({times}) 11 maui.layout.measure_duration (ns) Percentile 50 389,632 95 28,475,392 99 28,475,392 For this to work, you'd unfortunately need to build the app with: dotnet build -c Release -p:EnableDiagnostics=true -p:MetricsSupport=true -p:EventSourceSupport=true That's way too many properties to mess with! So, we should make the defaults: * For `Release` mode, `$(Optimize)` is `true`. * Only if `$(EnableDiagnostics)` is not `true`, then: * `$(MetricsSupport)` is `false`. * `$(EventSourceSupport)` is `false`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/jonathanpeppers/MauiAspireWithTelemetry/tree/peppers
Context: dotnet/maui#31058
We are in the process of adding
Metricsto .NET MAUI to enabledotnet-counterssuch as:For this to work, you'd unfortunately need to build the app with:
That's way too many properties to mess with!
So, we should make the defaults:
For
Releasemode,$(Optimize)istrue.Only if
$(AndroidEnableProfiler)and$(EnableDiagnostics)are nottrue, then:$(MetricsSupport)isfalse.$(EventSourceSupport)isfalse.I also refactored other properties that default to
falsein Release mode by checking the$(Optimize)property.